From b7527e78e71646c02e9ff5fc689b2b99b312ef9c Mon Sep 17 00:00:00 2001 From: Luca Favatella Date: Mon, 22 Jun 2015 22:01:39 +0100 Subject: [PATCH] Log error when view finds unknown column in model This stricter behaviour would have reported a more meaningful error easing investigation for issue #276 on Android 2.1. --- F-Droid/src/org/fdroid/fdroid/data/App.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/F-Droid/src/org/fdroid/fdroid/data/App.java b/F-Droid/src/org/fdroid/fdroid/data/App.java index 985dd749f..2ed33f98b 100644 --- a/F-Droid/src/org/fdroid/fdroid/data/App.java +++ b/F-Droid/src/org/fdroid/fdroid/data/App.java @@ -114,7 +114,8 @@ public class App extends ValueObject implements Comparable { checkCursorPosition(cursor); for (int i = 0; i < cursor.getColumnCount(); i++) { - switch (cursor.getColumnName(i)) { + String n = cursor.getColumnName(i); + switch (n) { case AppProvider.DataColumns.IS_COMPATIBLE: compatible = cursor.getInt(i) == 1; break; @@ -208,6 +209,10 @@ public class App extends ValueObject implements Comparable { case AppProvider.DataColumns.InstalledApp.VERSION_NAME: installedVersionName = cursor.getString(i); break; + case "_id": + break; + default: + Log.e(TAG, "Unknown column name " + n); } } }