Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

LocalRepoKeyStore.setupHTTPSCertificate() handles all exceptions itself

Browse Source 
Since there is nothing happening with the Exceptions anyway, they should be
handled in this method so that this method is easy to use elsewhere.
This commit is contained in:
Hans-Christoph Steiner 2014-05-23 16:49:48 -04:00
parent d5488fc5f1
commit b70986ef16
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/org/fdroid/fdroid/localrepo/LocalRepoKeyStore.java
View File

@ -133,24 +133,25 @@ public class LocalRepoKeyStore {
} }
} }
public void setupHTTPSCertificate() throws CertificateException, public void setupHTTPSCertificate() {
OperatorCreationException, KeyStoreException, NoSuchAlgorithmException, try {
FileNotFoundException, IOException, UnrecoverableKeyException { // Get the existing private/public keypair to use for the HTTPS cert
// Get the existing private/public keypair to use for the HTTPS cert KeyPair kerplappKeypair = getKerplappKeypair();
KeyPair kerplappKeypair = getKerplappKeypair();
/* /*
* Once we have an IP address, that can be used as the hostname. We can * Once we have an IP address, that can be used as the hostname. We
* generate a self signed cert with a valid CN field to stash into the * can generate a self signed cert with a valid CN field to stash
* keystore in a predictable place. If the IP address changes we should * into the keystore in a predictable place. If the IP address
* run this method again to stomp old HTTPS_CERT_ALIAS entries. * changes we should run this method again to stomp old
*/ * HTTPS_CERT_ALIAS entries.
X500Name subject = new X500Name("CN=" + FDroidApp.ipAddressString); */
X500Name subject = new X500Name("CN=" + FDroidApp.ipAddressString);
Certificate indexCert = generateSelfSignedCertChain(kerplappKeypair, subject, Certificate indexCert = generateSelfSignedCertChain(kerplappKeypair, subject,
FDroidApp.ipAddressString); FDroidApp.ipAddressString);
addToStore(HTTP_CERT_ALIAS, kerplappKeypair, indexCert);
addToStore(HTTP_CERT_ALIAS, kerplappKeypair, indexCert); } catch (Exception e) {
e.printStackTrace();
}
} }
public File getKeyStoreFile() { public File getKeyStoreFile() {