From ac8d3ff60025f22a589c37360047ffae7f2fc4c7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Thu, 28 Apr 2016 17:58:00 +0100
Subject: [PATCH] PMD: Enable and obey UnnecessaryParentheses

This works on statements, not expressions, so it's a lot easier and
saner to obey than UselessParentheses.
---
 .../main/java/org/fdroid/fdroid/net/WifiStateChangeService.java | 2 +-
 config/pmd/rules.xml                                            | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java b/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java
index 7b13d1683..160ca6197 100644
--- a/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java
+++ b/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java
@@ -219,7 +219,7 @@ public class WifiStateChangeService extends Service {
                             if (inetAddress.equals(address.getAddress()) && !TextUtils.isEmpty(FDroidApp.ipAddressString)) {
                                 String cidr = String.format(Locale.ENGLISH, "%s/%d",
                                         FDroidApp.ipAddressString, address.getNetworkPrefixLength());
-                                FDroidApp.subnetInfo = (new SubnetUtils(cidr)).getInfo();
+                                FDroidApp.subnetInfo = new SubnetUtils(cidr).getInfo();
                                 break;
                             }
                         }
diff --git a/config/pmd/rules.xml b/config/pmd/rules.xml
index 7e370f087..414454615 100644
--- a/config/pmd/rules.xml
+++ b/config/pmd/rules.xml
@@ -20,6 +20,7 @@
     <rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/>
 
     <rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>
+    <rule ref="rulesets/java/controversial.xml/UnnecessaryParentheses"/>
 
     <rule ref="rulesets/java/strictexception.xml/AvoidRethrowingException"/>
     <rule ref="rulesets/java/strictexception.xml/AvoidCatchingThrowable"/>