From ac1dce24d29d687f8e77f8d82cf66ecd4f4958ab Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Tue, 5 Sep 2017 12:56:05 +1000 Subject: [PATCH] Don't assume all apps have a preferred signer, as media apps don't Fixes #1156. --- app/src/main/java/org/fdroid/fdroid/data/App.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/data/App.java b/app/src/main/java/org/fdroid/fdroid/data/App.java index 16e2925a1..7f91f6113 100644 --- a/app/src/main/java/org/fdroid/fdroid/data/App.java +++ b/app/src/main/java/org/fdroid/fdroid/data/App.java @@ -1141,13 +1141,14 @@ public class App extends ValueObject implements Comparable, Parcelable { * the user to try and install versions with that signature (because thats all the OS will let * them do). */ - @NonNull + @Nullable public String getMostAppropriateSignature() { if (!TextUtils.isEmpty(installedSig)) { return installedSig; } else if (!TextUtils.isEmpty(preferredSigner)) { return preferredSigner; } - throw new IllegalStateException("Most Appropriate Signature not found!"); + + return null; } }