From ab917b62722709a827bd19986fa0fc026ab4e3da Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Thu, 1 Dec 2016 08:57:22 +1100 Subject: [PATCH] Remove need for setTag and (String) getTag() Can use the argument passed to addLinkItemView() instead. Requires making it final so that the anonymous inner class can read it. --- .../fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java index c1e654795..9ec4ca90e 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java +++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java @@ -697,16 +697,15 @@ public class AppDetailsRecyclerViewAdapter } } - private void addLinkItemView(ViewGroup parent, int resIdText, int resIdDrawable, String url) { + private void addLinkItemView(ViewGroup parent, int resIdText, int resIdDrawable, final String url) { TextView view = (TextView) LayoutInflater.from(parent.getContext()).inflate(R.layout.app_details2_link_item, parent, false); - view.setTag(url); view.setText(resIdText); TextViewCompat.setCompoundDrawablesRelativeWithIntrinsicBounds(view, resIdDrawable, 0, 0, 0); parent.addView(view); view.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { - onLinkClicked((String) v.getTag()); + onLinkClicked(url); } }); }