From aa877fd85a0013058b22c5fdade22678988b5edb Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Tue, 29 Jul 2014 15:43:00 -0400 Subject: [PATCH] Category Spinner should always look like a dropdown menu On Android 4.x, the category menu is showing up as pure black, and looks very much like an app list item. I've personally witnessed many new users struggle to find an app because the category is on "What's New" by default and the app they are looking for is not new. Some even had troubles remembering about the category menu after I told them. This small change makes the category dropdown look the same on all Android versions, and makes it a lot more apparent on newer Android releases. This is a temporary usability fix until we can do something much better than the category dropdown menu. --- .../fdroid/views/fragments/AvailableAppsFragment.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/org/fdroid/fdroid/views/fragments/AvailableAppsFragment.java b/src/org/fdroid/fdroid/views/fragments/AvailableAppsFragment.java index 29c3a2295..6d43781b5 100644 --- a/src/org/fdroid/fdroid/views/fragments/AvailableAppsFragment.java +++ b/src/org/fdroid/fdroid/views/fragments/AvailableAppsFragment.java @@ -7,13 +7,19 @@ import android.content.res.Resources; import android.database.ContentObserver; import android.database.Cursor; import android.net.Uri; +import android.os.Build; import android.os.Bundle; import android.support.v4.app.LoaderManager; import android.util.Log; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; -import android.widget.*; +import android.widget.AdapterView; +import android.widget.ArrayAdapter; +import android.widget.LinearLayout; +import android.widget.ListView; +import android.widget.Spinner; + import org.fdroid.fdroid.Preferences; import org.fdroid.fdroid.R; import org.fdroid.fdroid.compat.ArrayAdapterCompat; @@ -101,6 +107,9 @@ public class AvailableAppsFragment extends AppListFragment implements // Giving it an ID lets the default save/restore state // functionality do its stuff. categorySpinner.setId(R.id.categorySpinner); + // with holo, the menu gets lost since it looks the same as an app list item + if (Build.VERSION.SDK_INT >= 14) + categorySpinner.setBackgroundDrawable(getResources().getDrawable(android.R.drawable.btn_dropdown)); ArrayAdapter adapter = new ArrayAdapter( getActivity(), android.R.layout.simple_spinner_item, translatedCategories);