From a74e951cdf2e3f79f6dcb67b2488bc23ae25216c Mon Sep 17 00:00:00 2001
From: Peter Serwylo <peter@serwylo.com>
Date: Thu, 2 Jun 2016 14:46:58 +1000
Subject: [PATCH] Simplify code by creating the object when required rather
 than using singleton.

This should not be a particularly expensive opperation,. Also, at time of
writing it is only used in a background thread, and only used once in that
thread (i.e. not in a loop or anything like that).
---
 .../fdroid/fdroid/localrepo/LocalRepoManager.java    | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java b/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
index 3cf9b79b3..1e18438f7 100644
--- a/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
+++ b/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
@@ -319,16 +319,6 @@ public final class LocalRepoManager {
      * Helper class to aid in constructing index.xml file.
      */
     public static final class IndexXmlBuilder {
-
-        private static IndexXmlBuilder indexXmlBuilder;
-
-        public static IndexXmlBuilder get() throws XmlPullParserException {
-            if (indexXmlBuilder == null) {
-                indexXmlBuilder = new IndexXmlBuilder();
-            }
-            return indexXmlBuilder;
-        }
-
         @NonNull
         private final XmlSerializer serializer;
 
@@ -487,7 +477,7 @@ public final class LocalRepoManager {
         JarOutputStream jo = new JarOutputStream(bo);
         JarEntry je = new JarEntry("index.xml");
         jo.putNextEntry(je);
-        IndexXmlBuilder.get().build(context, apps, jo);
+        new IndexXmlBuilder().build(context, apps, jo);
         jo.close();
         bo.close();