Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix lint UnsafeProtectedBroadcastReceiver

Browse Source 
Android won't protect us from other apps sending other Intents to these
receivers, so at least check that the action string matches what its
looking for.  This is based on a lint recommendation.
This commit is contained in:
Hans-Christoph Steiner 2016-10-10 20:13:41 +02:00
parent e2256d3d8c
commit a5a90954bc
3 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/build.gradle
View File

@ -203,7 +203,7 @@ android {
// to make CI fail on errors until this is fixed https://github.com/rtyley/spongycastle/issues/7
warning 'InvalidPackage'
error 'AppCompatMethod', 'NestedScrolling', 'StringFormatCount'
error 'AppCompatMethod', 'NestedScrolling', 'StringFormatCount', 'UnsafeProtectedBroadcastReceiver'
}
packagingOptions {

8
app/src/main/java/org/fdroid/fdroid/receiver/StartupReceiver.java
View File

@ -23,12 +23,18 @@ import android.content.Context;
import android.content.Intent;
import org.fdroid.fdroid.UpdateService;
import org.fdroid.fdroid.Utils;
public class StartupReceiver extends BroadcastReceiver {
private static final String TAG = "StartupReceiver";
@Override
public void onReceive(Context ctx, Intent intent) {
UpdateService.schedule(ctx);
if (Intent.ACTION_BOOT_COMPLETED.equals(intent.getAction())) {
UpdateService.schedule(ctx);
} else {
Utils.debugLog(TAG, "received unsupported Intent " + intent);
}
}
}

11
app/src/main/java/org/fdroid/fdroid/receiver/WifiStateChangeReceiver.java
View File

@ -4,14 +4,21 @@ import android.content.BroadcastReceiver;
import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
import android.net.wifi.WifiManager;
import org.fdroid.fdroid.Utils;
import org.fdroid.fdroid.net.WifiStateChangeService;
public class WifiStateChangeReceiver extends BroadcastReceiver {
private static final String TAG = "WifiStateChangeReceiver";
@Override
public void onReceive(Context context, Intent intent) {
intent.setComponent(new ComponentName(context, WifiStateChangeService.class));
context.startService(intent);
if (WifiManager.NETWORK_STATE_CHANGED_ACTION.equals(intent.getAction())) {
intent.setComponent(new ComponentName(context, WifiStateChangeService.class));
context.startService(intent);
} else {
Utils.debugLog(TAG, "received unsupported Intent: " + intent);
}
}
}