diff --git a/app/src/main/java/org/fdroid/fdroid/NotificationHelper.java b/app/src/main/java/org/fdroid/fdroid/NotificationHelper.java index e06a27594..6b1a2ca87 100644 --- a/app/src/main/java/org/fdroid/fdroid/NotificationHelper.java +++ b/app/src/main/java/org/fdroid/fdroid/NotificationHelper.java @@ -273,7 +273,7 @@ class NotificationHelper { case Downloading: return app.name; case ReadyToInstall: - return context.getString(R.string.notification_title_single_ready_to_install_update); + return context.getString(app.isInstalled() ? R.string.notification_title_single_ready_to_install_update : R.string.notification_title_single_ready_to_install); case Installing: return app.name; case Installed: @@ -289,7 +289,7 @@ class NotificationHelper { case UpdateAvailable: return app.name; case Downloading: - return context.getString(R.string.notification_content_single_downloading_update, app.name); + return context.getString(app.isInstalled() ? R.string.notification_content_single_downloading_update : R.string.notification_content_single_downloading, app.name); case ReadyToInstall: return app.name; case Installing: @@ -302,14 +302,14 @@ class NotificationHelper { return ""; } - private String getMultiItemContentString(AppUpdateStatusManager.Status status) { + private String getMultiItemContentString(App app, AppUpdateStatusManager.Status status) { switch (status) { case UpdateAvailable: return context.getString(R.string.notification_title_summary_update_available); case Downloading: - return context.getString(R.string.notification_title_summary_downloading_update); + return context.getString(app.isInstalled() ? R.string.notification_title_summary_downloading_update : R.string.notification_title_summary_downloading); case ReadyToInstall: - return context.getString(R.string.notification_title_summary_ready_to_install_update); + return context.getString(app.isInstalled() ? R.string.notification_title_summary_ready_to_install_update : R.string.notification_title_summary_ready_to_install); case Installing: return context.getString(R.string.notification_title_summary_installing); case Installed: @@ -383,7 +383,7 @@ class NotificationHelper { App app = entry.app; AppUpdateStatusManager.Status status = entry.status; - String content = getMultiItemContentString(status); + String content = getMultiItemContentString(app, status); SpannableStringBuilder sb = new SpannableStringBuilder(app.name); sb.setSpan(new StyleSpan(Typeface.BOLD), 0, sb.length(), Spanned.SPAN_INCLUSIVE_EXCLUSIVE); sb.append(" "); diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index f1839d6e6..2976c7f7a 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -401,8 +401,10 @@ +%1$d more… Update Available + Ready to install Update ready to install Install Failed + Downloading \"%1$s\"… Downloading update for \"%1$s\"… Installing \"%1$s\"… Successfully installed @@ -410,7 +412,9 @@ %1$d Updates %1$d Apps Installed Update available + Downloading… Downloading update… + Ready to install Update ready to install Installing Successfully installed