From a3ac298ae4d84cb008bf8111b3f965cb69c4ca9f Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Mon, 2 Dec 2013 15:37:49 -0500 Subject: [PATCH] narrowly tailor repo URL matching to avoid false matches With so many patterns being matched, it is highly likely that there will be false positives, i.e. random URLs will trigger the prompt of whether to use F-Droid or not. The updated set of patterns narrowly tailors the matches so that it is highly unlikely to match URLs that are not fdroid repos, yet still makes it useful both as a generic repo and a peer-to-peer bootstrapping repo. This set of patterns only matches URLs like this: https://foo.org/fdroid/repo https://foo.org/fdroid/repo/ https://foo.org/fdroid/repo///// It does not match URLs like this: https://f-droid.org/repo https://myblog.com/thoughts-about-my-lovely-fdroid-repo https://news.com/tag/repo https://somesite.com/repo/this-is-my-stuff It matches multiple slashes to since those are in effect the same URL, and they sometimes show up as typos. This does not include mvdan's proposal for the 'fdroid-bootstrap' tag on the end because its not something that I would use in this current project, so I don't know how best to apply it. I have no objection to the 'fdroid-bootstrap' proposal. --- AndroidManifest.xml | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index b23692682..e9e3f1a3a 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -78,24 +78,28 @@ - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + +