From 98aea0127223fb43b4579a8ee91b8482ae8bb4d3 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 6 Apr 2018 11:14:48 +0200 Subject: [PATCH] remove confusing Exception when checking permissions Might as well just let things fail with a NullPointerException, that will provide more information around the crash. --- app/src/main/java/org/fdroid/fdroid/installer/Installer.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/installer/Installer.java b/app/src/main/java/org/fdroid/fdroid/installer/Installer.java index c60d53883..86739fa06 100644 --- a/app/src/main/java/org/fdroid/fdroid/installer/Installer.java +++ b/app/src/main/java/org/fdroid/fdroid/installer/Installer.java @@ -113,10 +113,6 @@ public abstract class Installer { } AppDiff appDiff = new AppDiff(context.getPackageManager(), apk); - if (appDiff.pkgInfo == null) { - // could not get diff because we couldn't parse the package - throw new RuntimeException("cannot parse!"); - } AppSecurityPermissions perms = new AppSecurityPermissions(context, appDiff.pkgInfo); if (appDiff.installedAppInfo != null) { // update to an existing app