From 97ad4ddc1fd9fefb1fad86d9da246a64c2208c94 Mon Sep 17 00:00:00 2001
From: Hans-Christoph Steiner <hans@eds.org>
Date: Mon, 7 Jan 2019 16:31:32 +0100
Subject: [PATCH] get HttpDownloaderTest working on at least android-17 and
 above

The two excluded URLs seem to always resolve to IPv6 addresses first, then
fail since there isn't IPv6 connectivity. Donno why, but only on old android
versions, so just skip them there.
---
 .../fdroid/fdroid/net/HttpDownloaderTest.java | 39 ++++++++++++++-----
 1 file changed, 29 insertions(+), 10 deletions(-)

diff --git a/app/src/androidTest/java/org/fdroid/fdroid/net/HttpDownloaderTest.java b/app/src/androidTest/java/org/fdroid/fdroid/net/HttpDownloaderTest.java
index 47400116c..57238613d 100644
--- a/app/src/androidTest/java/org/fdroid/fdroid/net/HttpDownloaderTest.java
+++ b/app/src/androidTest/java/org/fdroid/fdroid/net/HttpDownloaderTest.java
@@ -2,11 +2,15 @@
 package org.fdroid.fdroid.net;
 
 import android.net.Uri;
+import android.os.Build;
+import android.util.Log;
 import org.fdroid.fdroid.ProgressListener;
 import org.junit.Test;
 
 import java.io.File;
 import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 
@@ -15,22 +19,37 @@ import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 public class HttpDownloaderTest {
+    private static final String TAG = "HttpDownloaderTest";
 
-    final String[] urls = {
-            "https://en.wikipedia.org/wiki/Index.html",
-            "https://mirrors.kernel.org/debian/dists/stable/Release",
-            "https://f-droid.org/repo/index.jar",
-            // sites that use SNI for HTTPS
-            "https://guardianproject.info/fdroid/repo/index.jar",
-            //"https://microg.org/fdroid/repo/index.jar",
-            //"https://grobox.de/fdroid/repo/index.jar",
-    };
+    static final String[] URLS;
+
+    // https://developer.android.com/reference/javax/net/ssl/SSLContext
+    static {
+        ArrayList<String> tempUrls = new ArrayList<>(Arrays.asList(
+                "https://f-droid.org/repo/index-v1.jar",
+                // sites that use SNI for HTTPS
+                "https://mirrors.kernel.org/debian/dists/stable/Release",
+                "https://fdroid.tetaneutral.net/fdroid/repo/index-v1.jar",
+                "https://ftp.fau.de/fdroid/repo/index-v1.jar",
+                //"https://microg.org/fdroid/repo/index-v1.jar",
+                //"https://grobox.de/fdroid/repo/index.jar",
+                "https://guardianproject.info/fdroid/repo/index-v1.jar"
+        ));
+        if (Build.VERSION.SDK_INT >= 22) {
+            tempUrls.addAll(Arrays.asList(
+                    "https://en.wikipedia.org/wiki/Index.html", // no SNI but weird ipv6 lookup issues
+                    "https://mirror.cyberbits.eu/fdroid/repo/index-v1.jar"  // TLSv1.2 only and SNI
+            ));
+        }
+        URLS = tempUrls.toArray(new String[tempUrls.size()]);
+    }
 
     private boolean receivedProgress;
 
     @Test
     public void downloadUninterruptedTest() throws IOException, InterruptedException {
-        for (String urlString : urls) {
+        for (String urlString : URLS) {
+            Log.i(TAG, "URL: " + urlString);
             Uri uri = Uri.parse(urlString);
             File destFile = File.createTempFile("dl-", "");
             HttpDownloader httpDownloader = new HttpDownloader(uri, destFile);