Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove unused arg from FileCompat.setReadable()

Browse Source 
Just trying to keep the code as close to what is actually used as possible.
This commit is contained in:
Hans-Christoph Steiner 2016-04-13 12:20:06 -04:00
parent 32fc118b3d
commit 972ef3b078
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/src/main/java/org/fdroid/fdroid/compat/FileCompat.java
View File

@ -85,20 +85,21 @@ public class FileCompat {
} }
} }
/**
* Set a {@link SanitizedFile} readable by all if {@code readable} is {@code true}.
*
* @return {@code true} if the operation succeeded
*/
@TargetApi(9) @TargetApi(9)
public static boolean setReadable(SanitizedFile file, boolean readable, boolean ownerOnly) { public static boolean setReadable(SanitizedFile file, boolean readable) {
if (Build.VERSION.SDK_INT >= 9) { if (Build.VERSION.SDK_INT >= 9) {
return file.setReadable(readable, ownerOnly); return file.setReadable(readable, false);
} }
String mode;
if (readable) { if (readable) {
mode = ownerOnly ? "0600" : "0644"; return setMode(file, "0644");
} else { } else {
mode = "0000"; return setMode(file, "0000");
} }
return setMode(file, mode);
} }
private static boolean setMode(SanitizedFile file, String mode) { private static boolean setMode(SanitizedFile file, String mode) {

2
app/src/main/java/org/fdroid/fdroid/installer/Installer.java
View File

@ -222,7 +222,7 @@ public abstract class Installer {
// have access is insecure, because apps with permission to write to the external // have access is insecure, because apps with permission to write to the external
// storage can overwrite the app between F-Droid asking for it to be installed and // storage can overwrite the app between F-Droid asking for it to be installed and
// the installer actually installing it. // the installer actually installing it.
FileCompat.setReadable(apkToInstall, true, false); FileCompat.setReadable(apkToInstall, true);
installPackageInternal(apkToInstall); installPackageInternal(apkToInstall);
NotificationManager nm = (NotificationManager) NotificationManager nm = (NotificationManager)