From 94fb0c8a029dd164dc04da661ffea2d664143f56 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Wed, 19 Feb 2014 16:29:51 -0500 Subject: [PATCH] prevent crash when clicking on the header in "Repositories" view Here's the crash dump: java.lang.NullPointerException at org.fdroid.fdroid.data.ValueObject.checkCursorPosition(ValueObject.java:13) at org.fdroid.fdroid.data.Repo.(Repo.java:37) at org.fdroid.fdroid.views.fragments.RepoListFragment.onListItemClick(RepoListFragment.java:269) at android.support.v4.app.ListFragment$2.onItemClick(ListFragment.java:58) at android.widget.AdapterView.performItemClick(AdapterView.java:299) at android.widget.AbsListView.performItemClick(AbsListView.java:1113) at android.widget.AbsListView$PerformClick.run(AbsListView.java:2904) at android.widget.AbsListView$3.run(AbsListView.java:3638) at android.os.Handler.handleCallback(Handler.java:733) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5017) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) at dalvik.system.NativeStart.main(Native Method) --- src/org/fdroid/fdroid/views/fragments/RepoListFragment.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/fdroid/fdroid/views/fragments/RepoListFragment.java b/src/org/fdroid/fdroid/views/fragments/RepoListFragment.java index d07e2fa00..c4ea3c761 100644 --- a/src/org/fdroid/fdroid/views/fragments/RepoListFragment.java +++ b/src/org/fdroid/fdroid/views/fragments/RepoListFragment.java @@ -163,7 +163,7 @@ public class RepoListFragment extends ListFragment // Can't do this in the onCreate view, because "onCreateView" which // returns the list view is "called between onCreate and // onActivityCreated" according to the docs. - getListView().addHeaderView(createHeaderView()); + getListView().addHeaderView(createHeaderView(), null, false); // This could go in onCreate (and used to) but it needs to be called // after addHeaderView, which can only be called after onCreate...