From 94c4374bf79997edc35b79e379b5bdf3d542aef0 Mon Sep 17 00:00:00 2001
From: Andrew Gaul <andrew@gaul.org>
Date: Sun, 28 Jan 2018 12:46:21 -0800
Subject: [PATCH] Make some inner classes static

This avoids an implicit this field and can help GC.  Found via
error-prone.
---
 .../fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java    | 4 ++--
 .../java/org/fdroid/fdroid/views/ScreenShotsActivity.java     | 4 ++--
 .../org/fdroid/fdroid/views/whatsnew/WhatsNewAdapter.java     | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
index fa00a20ab..d8299365a 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
@@ -570,7 +570,7 @@ public class AppDetailsRecyclerViewAdapter
         super.onDetachedFromRecyclerView(recyclerView);
     }
 
-    private abstract class AppDetailsViewHolder extends RecyclerView.ViewHolder {
+    private abstract static class AppDetailsViewHolder extends RecyclerView.ViewHolder {
         AppDetailsViewHolder(View itemView) {
             super(itemView);
         }
@@ -664,7 +664,7 @@ public class AppDetailsRecyclerViewAdapter
         }
     }
 
-    private abstract class ExpandableLinearLayoutViewHolder extends AppDetailsViewHolder {
+    private abstract static class ExpandableLinearLayoutViewHolder extends AppDetailsViewHolder {
         final TextView headerView;
         final LinearLayout contentView;
 
diff --git a/app/src/main/java/org/fdroid/fdroid/views/ScreenShotsActivity.java b/app/src/main/java/org/fdroid/fdroid/views/ScreenShotsActivity.java
index a35de513c..d85988026 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/ScreenShotsActivity.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/ScreenShotsActivity.java
@@ -66,7 +66,7 @@ public class ScreenShotsActivity extends AppCompatActivity {
         }
     }
 
-    private class ScreenShotPagerAdapter extends FragmentStatePagerAdapter {
+    private static class ScreenShotPagerAdapter extends FragmentStatePagerAdapter {
 
         private final String[] screenshots;
 
@@ -133,7 +133,7 @@ public class ScreenShotsActivity extends AppCompatActivity {
     }
 
     @TargetApi(11)
-    public class DepthPageTransformer implements ViewPager.PageTransformer {
+    public static class DepthPageTransformer implements ViewPager.PageTransformer {
 
         public void transformPage(View view, float position) {
             int pageWidth = view.getWidth();
diff --git a/app/src/main/java/org/fdroid/fdroid/views/whatsnew/WhatsNewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/whatsnew/WhatsNewAdapter.java
index 659920592..7500f16d6 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/whatsnew/WhatsNewAdapter.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/whatsnew/WhatsNewAdapter.java
@@ -112,7 +112,7 @@ public class WhatsNewAdapter extends RecyclerView.Adapter<AppCardController> {
      * @see org.fdroid.fdroid.R.dimen#whats_new__padding__app_card__horizontal
      * @see org.fdroid.fdroid.R.dimen#whats_new__padding__app_card__vertical
      */
-    private class ItemDecorator extends RecyclerView.ItemDecoration {
+    private static class ItemDecorator extends RecyclerView.ItemDecoration {
         private final Context context;
 
         ItemDecorator(Context context) {