Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

equals() and hashCode() should always be overridden together

Browse Source 
This addressed the PMD error:
"Ensure you override both equals() and hashCode()"

#623 https://gitlab.com/fdroid/fdroidclient/issues/623
This commit is contained in:
Hans-Christoph Steiner 2016-05-11 16:46:40 +02:00
parent 23dad31426
commit 93433cff05
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/fdroid/fdroid/localrepo/peers/BluetoothPeer.java
View File

@ -34,6 +34,11 @@ public class BluetoothPeer implements Peer {
return peer != null && peer instanceof BluetoothPeer && ((BluetoothPeer) peer).device.getAddress().equals(device.getAddress()); return peer != null && peer instanceof BluetoothPeer && ((BluetoothPeer) peer).device.getAddress().equals(device.getAddress());
} }
@Override
public int hashCode() {
return device.getAddress().hashCode();
}
@Override @Override
public String getRepoAddress() { public String getRepoAddress() {
return "bluetooth://" + device.getAddress().replace(':', '-') + "/fdroid/repo"; return "bluetooth://" + device.getAddress().replace(':', '-') + "/fdroid/repo";

5
app/src/main/java/org/fdroid/fdroid/localrepo/peers/BonjourPeer.java
View File

@ -36,6 +36,11 @@ public class BonjourPeer extends WifiPeer {
return false; return false;
} }
@Override
public int hashCode() {
return getFingerprint().hashCode();
}
@Override @Override
public String getRepoAddress() { public String getRepoAddress() {
return serviceInfo.getRepoAddress(); return serviceInfo.getRepoAddress();