From 82bca90009bfc8abf9ef39cb6b6b491744db9488 Mon Sep 17 00:00:00 2001 From: Marcus Hoffmann Date: Mon, 15 Jun 2020 20:39:56 +0200 Subject: [PATCH] UpdateService: fix update scheduling condition This was blocking updates being scheduled when either data or wifi updates were disabled. We only want to completely disable the update service when both are disbaled though. Ref: #1623 --- app/src/main/java/org/fdroid/fdroid/UpdateService.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/UpdateService.java b/app/src/main/java/org/fdroid/fdroid/UpdateService.java index b81397a4b..035ae93f3 100644 --- a/app/src/main/java/org/fdroid/fdroid/UpdateService.java +++ b/app/src/main/java/org/fdroid/fdroid/UpdateService.java @@ -146,8 +146,7 @@ public class UpdateService extends JobIntentService { int wifi = prefs.getOverWifi(); boolean scheduleNewJob = interval != Preferences.UPDATE_INTERVAL_DISABLED - && data != Preferences.OVER_NETWORK_NEVER - && wifi != Preferences.OVER_NETWORK_NEVER; + && !(data == Preferences.OVER_NETWORK_NEVER && wifi == Preferences.OVER_NETWORK_NEVER); if (Build.VERSION.SDK_INT < 21) { Intent intent = new Intent(context, UpdateService.class);