From 86908ceeaa3dc8ce3c10511f821afcabae8a1e88 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 10 May 2019 12:00:20 +0200 Subject: [PATCH] the calculated ETag should be compared to the stored ETag Thanks to @amiraliakbari for tracking this down! closes fdroid/fdroidclient#1737 --- app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java b/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java index 231484639..243613425 100644 --- a/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java +++ b/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java @@ -147,9 +147,9 @@ public class HttpDownloader extends Downloader { } else { String calcedETag = String.format("\"%x-%x\"", tmpConn.getLastModified() / 1000, contentLength); - if (calcedETag.equals(headETag)) { + if (cacheTag.equals(calcedETag)) { Utils.debugLog(TAG, urlString + " cached based on calced ETag, not downloading: " + - headETag); + calcedETag); return; } }