Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

checkstyle: proper multiple empty line check

Browse Source 
Hopefully checkstyle could catch all of these on its own one day. For
now, help it via a multiline regex.
This commit is contained in:
Daniel Martí 2015-11-30 11:24:25 +01:00
parent 1e79b6d1d5
commit 8405ba7d87
12 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
F-Droid/src/com/google/zxing/integration/android/IntentIntegrator.java
View File

@ -400,7 +400,6 @@ public class IntentIntegrator {
return downloadDialog.show();
}
/**
* <p>Call this from your {@link Activity}'s
* {@link Activity#onActivityResult(int, int, Intent)} method.</p>
@ -432,7 +431,6 @@ public class IntentIntegrator {
return null;
}
/**
* Defaults to type "TEXT_TYPE".
*

1
F-Droid/src/org/fdroid/fdroid/AppDetails.java
View File

@ -1205,7 +1205,6 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
final TextView summaryView = (TextView) view.findViewById(R.id.summary);
summaryView.setText(app.summary);
layoutLinks = (ViewGroup) view.findViewById(R.id.ll_information);
layoutLinksContent = (ViewGroup) layoutLinks.findViewById(R.id.ll_information_content);

5
F-Droid/src/org/fdroid/fdroid/localrepo/SwapService.java
View File

@ -116,7 +116,6 @@ public class SwapService extends Service {
bluetoothFinder.cancel();
}
// ==========================================================
// Manage the current step
// ("Step" refers to the current view being shown in the UI)
@ -287,7 +286,6 @@ public class SwapService extends Service {
@Retention(RetentionPolicy.SOURCE)
public @interface SwapStep { }
// =================================================
// Have selected a specific peer to swap with
// (Rather than showing a generic QR code to scan)
@ -312,7 +310,6 @@ public class SwapService extends Service {
return peer;
}
// ==========================================
// Remember apps user wants to swap
// ==========================================
@ -373,7 +370,6 @@ public class SwapService extends Service {
persistAppsToSwap();
}
// =============================================================
// Remember which swap technologies a user used in the past
// =============================================================
@ -469,7 +465,6 @@ public class SwapService extends Service {
public static final String ACTION_PEER_FOUND = "org.fdroid.fdroid.SwapManager.ACTION_PEER_FOUND";
public static final String EXTRA_PEER = "EXTRA_PEER";
// ===============================================================
// Old SwapService stuff being merged into that.
// ===============================================================

2
F-Droid/src/org/fdroid/fdroid/localrepo/type/BluetoothSwap.java
View File

@ -44,8 +44,6 @@ public final class BluetoothSwap extends SwapType {
private BluetoothSwap(@NonNull Context context, @NonNull BluetoothAdapter adapter) {
super(context);
this.adapter = adapter;
}
@Override

1
F-Droid/src/org/fdroid/fdroid/net/AsyncDownloaderFromAndroid.java
View File

@ -341,7 +341,6 @@ public class AsyncDownloaderFromAndroid implements AsyncDownloader {
return -1;
}
/**
* Check if download was valid, see issue
* http://code.google.com/p/android/issues/detail?id=18462

1
F-Droid/src/org/fdroid/fdroid/net/bluetooth/BluetoothClient.java
View File

@ -23,7 +23,6 @@ public class BluetoothClient {
public BluetoothConnection openConnection() throws IOException {
BluetoothSocket socket = null;
BluetoothConnection connection = null;
try {

1
F-Droid/src/org/fdroid/fdroid/net/bluetooth/BluetoothServer.java
View File

@ -358,5 +358,4 @@ public class BluetoothServer extends Thread {
}
}
}

1
F-Droid/src/org/fdroid/fdroid/views/fragments/PreferencesFragment.java
View File

@ -320,5 +320,4 @@ public class PreferencesFragment extends PreferenceFragment
updateSummary(key, true);
}
}

1
F-Droid/test/src/android/test/ProviderTestCase2MockContext.java
View File

@ -168,7 +168,6 @@ public abstract class ProviderTestCase2MockContext<T extends ContentProvider> ex
}
}
/**
* Gets the {@link MockContentResolver} created by this class during initialization. You
* must use the methods of this resolver to access the provider under test.

1
F-Droid/test/src/org/fdroid/fdroid/TestUtils.java
View File

@ -222,7 +222,6 @@ public class TestUtils {
Context context = instrumentation.getContext();
Context targetContext = instrumentation.getTargetContext();
File[] dirsToTry = new File[]{
context.getCacheDir(),
context.getFilesDir(),

1
F-Droid/test/src/org/fdroid/fdroid/compat/FileCompatForTest.java
View File

@ -24,5 +24,4 @@ public class FileCompatForTest extends FileCompat {
symlinkLibcore(source, dest);
}
}

8
config/checkstyle/checkstyle.xml
View File

@ -14,6 +14,14 @@
<property name="severity" value="info" />
</module>
<module name="RegexpMultiline">
<property name="format" value="\n\n\n" />
<property name="minimum" value="0" />
<property name="maximum" value="0" />
<property name="message" value="Multiple empty lines found." />
<property name="severity" value="info" />
</module>
<module name="TreeWalker">
<!--<module name="ConstantName" />-->