From 834c08db3c3b2ec31dcc2ba3fca56a429457ddc7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Sch=C3=BCrmann?= Date: Sun, 1 May 2016 23:14:29 +0200 Subject: [PATCH] Code cleanup in Installer --- .../main/java/org/fdroid/fdroid/installer/Installer.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/installer/Installer.java b/app/src/main/java/org/fdroid/fdroid/installer/Installer.java index bd85b71f0..815384314 100644 --- a/app/src/main/java/org/fdroid/fdroid/installer/Installer.java +++ b/app/src/main/java/org/fdroid/fdroid/installer/Installer.java @@ -162,10 +162,7 @@ public abstract class Installer { return false; } Hasher hasher = new Hasher(hashType, apkFile); - if (hasher != null && hasher.match(hash)) { - return true; - } - return false; + return hasher.match(hash); } /** @@ -173,7 +170,7 @@ public abstract class Installer { */ public void installPackage(File apkFile, String packageName, String urlString) throws InstallFailedException { - SanitizedFile apkToInstall = null; + SanitizedFile apkToInstall; try { Map attributes = AndroidXMLDecompress.getManifestHeaderAttributes(apkFile.getAbsolutePath());