Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

enable PMD's java-basic ruleset

Browse Source 
* CollapsibleIfStatements is pedantic
* that one NOPMD is for debug logging, it'll go away

closes #623 https://gitlab.com/fdroid/fdroidclient/issues/623
This commit is contained in:
Hans-Christoph Steiner 2016-05-12 09:36:08 +02:00
parent 93433cff05
commit 7fbdfaaae7
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/fdroid/fdroid/views/swap/SwapWorkflowActivity.java
View File

@ -740,7 +740,7 @@ public class SwapWorkflowActivity extends AppCompatActivity {
public void logStatus() { public void logStatus() {
if (true) return; if (true) return; // NOPMD
String message = ""; String message = "";
if (service == null) { if (service == null) {

4
config/pmd/rules.xml
View File

@ -5,7 +5,9 @@
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd" xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd"> xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
<!--<rule ref="rulesets/java/basic.xml"/>--> <rule ref="rulesets/java/basic.xml">
<exclude name="CollapsibleIfStatements"/> <!--sometimes forces hard to read code-->
</rule>
<rule ref="rulesets/java/unusedcode.xml"/> <rule ref="rulesets/java/unusedcode.xml"/>
<rule ref="rulesets/java/android.xml"/> <rule ref="rulesets/java/android.xml"/>
<rule ref="rulesets/java/clone.xml"/> <rule ref="rulesets/java/clone.xml"/>