From 7e83189f5b5722ed9592ff36a96689a8d55294c6 Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Fri, 22 Apr 2016 23:53:13 +1000 Subject: [PATCH] Appese checkstyle + pmd. --- app/src/main/java/org/fdroid/fdroid/AppDetails.java | 2 +- .../java/org/fdroid/fdroid/net/DownloadCompleteService.java | 3 --- .../main/java/org/fdroid/fdroid/net/DownloaderService.java | 6 +++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/AppDetails.java b/app/src/main/java/org/fdroid/fdroid/AppDetails.java index a9288bed2..149065263 100644 --- a/app/src/main/java/org/fdroid/fdroid/AppDetails.java +++ b/app/src/main/java/org/fdroid/fdroid/AppDetails.java @@ -426,7 +426,7 @@ public class AppDetails extends AppCompatActivity { @Override protected void onResumeFragments() { super.onResumeFragments(); - headerFragment = (AppDetailsHeaderFragment)getSupportFragmentManager().findFragmentById(R.id.header); + headerFragment = (AppDetailsHeaderFragment) getSupportFragmentManager().findFragmentById(R.id.header); refreshApkList(); supportInvalidateOptionsMenu(); if (DownloaderService.isQueuedOrActive(activeDownloadUrlString)) { diff --git a/app/src/main/java/org/fdroid/fdroid/net/DownloadCompleteService.java b/app/src/main/java/org/fdroid/fdroid/net/DownloadCompleteService.java index 4cdb761d7..fa5029d94 100644 --- a/app/src/main/java/org/fdroid/fdroid/net/DownloadCompleteService.java +++ b/app/src/main/java/org/fdroid/fdroid/net/DownloadCompleteService.java @@ -2,17 +2,14 @@ package org.fdroid.fdroid.net; import android.app.IntentService; import android.app.NotificationManager; -import android.app.PendingIntent; import android.content.Context; import android.content.Intent; import android.content.pm.PackageManager; import android.net.Uri; import android.os.Process; import android.support.v4.app.NotificationCompat; -import android.support.v4.app.TaskStackBuilder; import android.text.TextUtils; -import org.fdroid.fdroid.AppDetails; import org.fdroid.fdroid.R; import org.fdroid.fdroid.Utils; import org.fdroid.fdroid.data.App; diff --git a/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java b/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java index c56cba2b2..2d31a6574 100644 --- a/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java +++ b/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java @@ -182,7 +182,7 @@ public class DownloaderService extends Service { String title; if (packageName != null) { App app = AppProvider.Helper.findByPackageName( - getContentResolver(), packageName, new String[] { AppProvider.DataColumns.NAME }); + getContentResolver(), packageName, new String[] {AppProvider.DataColumns.NAME}); title = getString(R.string.downloading_apk, app.name); } else { title = getString(R.string.downloading); @@ -365,7 +365,7 @@ public class DownloaderService extends Service { * @see DownloaderService#isActive(String) */ public static boolean isQueuedOrActive(String urlString) { - return isQueued(urlString) || isActive(urlString); + return isQueued(urlString) || isActive(urlString); } public static boolean isQueueEmpty() { @@ -380,7 +380,7 @@ public class DownloaderService extends Service { return false; } Integer what = QUEUE_WHATS.get(urlString); - return (what != null && serviceHandler.hasMessages(what)); + return what != null && serviceHandler.hasMessages(what); } /**