checkstyle: Add EmptyLineSeparator

This commit is contained in:
Daniel Martí 2015-10-08 22:23:10 +02:00
parent f5352eaf28
commit 7bbcbf25a6
14 changed files with 34 additions and 0 deletions

View File

@ -14,6 +14,7 @@
* limitations under the License. * limitations under the License.
*/ */
// from https://stackoverflow.com/questions/4782543/integration-zxing-library-directly-into-my-android-application // from https://stackoverflow.com/questions/4782543/integration-zxing-library-directly-into-my-android-application
package com.google.zxing.encode; package com.google.zxing.encode;
import android.graphics.Bitmap; import android.graphics.Bitmap;

View File

@ -14,6 +14,7 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
package org.apache.commons.io.input; package org.apache.commons.io.input;
import java.io.IOException; import java.io.IOException;

View File

@ -103,8 +103,11 @@ import java.util.List;
interface AppDetailsData { interface AppDetailsData {
App getApp(); App getApp();
AppDetails.ApkListAdapter getApks(); AppDetails.ApkListAdapter getApks();
Signature getInstalledSignature(); Signature getInstalledSignature();
String getInstalledSignatureId(); String getInstalledSignatureId();
} }
@ -118,6 +121,7 @@ interface AppDetailsData {
*/ */
interface AppInstallListener { interface AppInstallListener {
void install(final Apk apk); void install(final Apk apk);
void removeApk(String packageName); void removeApk(String packageName);
} }

View File

@ -14,8 +14,11 @@ public abstract class LayoutCompat extends Compatibility {
private static final LayoutCompat impl = LayoutCompat.create(); private static final LayoutCompat impl = LayoutCompat.create();
protected abstract int relativeLayoutStartOf(); protected abstract int relativeLayoutStartOf();
protected abstract int relativeLayoutEndOf(); protected abstract int relativeLayoutEndOf();
protected abstract int relativeLayoutAlignParentStart(); protected abstract int relativeLayoutAlignParentStart();
protected abstract int relativeLayoutAlignParentEnd(); protected abstract int relativeLayoutAlignParentEnd();
public static class RelativeLayout { public static class RelativeLayout {

View File

@ -20,6 +20,7 @@ public abstract class PeerFinder<T extends Peer> {
protected final Context context; protected final Context context;
public abstract void scan(); public abstract void scan();
public abstract void cancel(); public abstract void cancel();
public PeerFinder(Context context) { public PeerFinder(Context context) {

View File

@ -6,13 +6,18 @@ public interface AsyncDownloader {
interface Listener extends ProgressListener { interface Listener extends ProgressListener {
void onErrorDownloading(String localisedExceptionDetails); void onErrorDownloading(String localisedExceptionDetails);
void onDownloadComplete(); void onDownloadComplete();
void onDownloadCancelled(); void onDownloadCancelled();
} }
int getBytesRead(); int getBytesRead();
int getTotalBytes(); int getTotalBytes();
void download(); void download();
void attemptCancel(boolean userRequested); void attemptCancel(boolean userRequested);
} }

View File

@ -36,6 +36,7 @@ public abstract class Downloader {
protected int totalBytes; protected int totalBytes;
public abstract InputStream getInputStream() throws IOException; public abstract InputStream getInputStream() throws IOException;
public abstract void close(); public abstract void close();
Downloader(Context context, URL url, File destFile) Downloader(Context context, URL url, File destFile)

View File

@ -12,6 +12,7 @@ public abstract class Header {
}; };
protected abstract String getName(); protected abstract String getName();
protected abstract void handle(FileDetails details, String value); protected abstract void handle(FileDetails details, String value);
public static void process(FileDetails details, String header, String value) { public static void process(FileDetails details, String header, String value) {

View File

@ -15,6 +15,7 @@
** See the License for the specific language governing permissions and ** See the License for the specific language governing permissions and
** limitations under the License. ** limitations under the License.
*/ */
package org.fdroid.fdroid.privileged.views; package org.fdroid.fdroid.privileged.views;
import android.annotation.TargetApi; import android.annotation.TargetApi;
@ -459,9 +460,12 @@ public class AppSecurityPermissions {
} }
private static class PermissionGroupInfoComparator implements Comparator<MyPermissionGroupInfo> { private static class PermissionGroupInfoComparator implements Comparator<MyPermissionGroupInfo> {
private final Collator sCollator = Collator.getInstance(); private final Collator sCollator = Collator.getInstance();
PermissionGroupInfoComparator() { PermissionGroupInfoComparator() {
} }
public final int compare(MyPermissionGroupInfo a, MyPermissionGroupInfo b) { public final int compare(MyPermissionGroupInfo a, MyPermissionGroupInfo b) {
if (((a.flags() ^ b.flags()) & PermissionGroupInfo.FLAG_PERSONAL_INFO) != 0) { if (((a.flags() ^ b.flags()) & PermissionGroupInfo.FLAG_PERSONAL_INFO) != 0) {
return ((a.flags() & PermissionGroupInfo.FLAG_PERSONAL_INFO) != 0) ? -1 : 1; return ((a.flags() & PermissionGroupInfo.FLAG_PERSONAL_INFO) != 0) ? -1 : 1;
@ -474,9 +478,12 @@ public class AppSecurityPermissions {
} }
private static class PermissionInfoComparator implements Comparator<MyPermissionInfo> { private static class PermissionInfoComparator implements Comparator<MyPermissionInfo> {
private final Collator sCollator = Collator.getInstance(); private final Collator sCollator = Collator.getInstance();
PermissionInfoComparator() { PermissionInfoComparator() {
} }
public final int compare(MyPermissionInfo a, MyPermissionInfo b) { public final int compare(MyPermissionInfo a, MyPermissionInfo b) {
return sCollator.compare(a.mLabel, b.mLabel); return sCollator.compare(a.mLabel, b.mLabel);
} }

View File

@ -14,6 +14,7 @@
** See the License for the specific language governing permissions and ** See the License for the specific language governing permissions and
** limitations under the License. ** limitations under the License.
*/ */
package org.fdroid.fdroid.privileged.views; package org.fdroid.fdroid.privileged.views;
import android.app.Activity; import android.app.Activity;

View File

@ -33,6 +33,7 @@ abstract class PackageReceiver extends BroadcastReceiver {
private static final String TAG = "PackageReceiver"; private static final String TAG = "PackageReceiver";
protected abstract boolean toDiscard(Intent intent); protected abstract boolean toDiscard(Intent intent);
protected abstract void handle(Context context, String appId); protected abstract void handle(Context context, String appId);
protected PackageInfo getPackageInfo(Context context, String appId) { protected PackageInfo getPackageInfo(Context context, String appId) {

View File

@ -168,6 +168,7 @@ public class AvailableAppsFragment extends AppListFragment implements
getListView().setSelection(0); getListView().setSelection(0);
setCurrentCategory(categories.get(pos)); setCurrentCategory(categories.get(pos));
} }
@Override @Override
public void onNothingSelected(AdapterView<?> parent) { public void onNothingSelected(AdapterView<?> parent) {
setCurrentCategory(null); setCurrentCategory(null);

View File

@ -125,6 +125,7 @@ public class SwapConnecting extends LinearLayout implements SwapWorkflowActivity
return status == UpdateService.STATUS_COMPLETE_AND_SAME || return status == UpdateService.STATUS_COMPLETE_AND_SAME ||
status == UpdateService.STATUS_COMPLETE_WITH_CHANGES; status == UpdateService.STATUS_COMPLETE_WITH_CHANGES;
} }
@Override @Override
protected boolean isError(Intent intent) { protected boolean isError(Intent intent) {
int status = getStatusCode(intent); int status = getStatusCode(intent);
@ -143,8 +144,11 @@ public class SwapConnecting extends LinearLayout implements SwapWorkflowActivity
abstract class Receiver extends BroadcastReceiver { abstract class Receiver extends BroadcastReceiver {
protected abstract String getMessageExtra(); protected abstract String getMessageExtra();
protected abstract boolean isComplete(Intent intent); protected abstract boolean isComplete(Intent intent);
protected abstract boolean isError(Intent intent); protected abstract boolean isError(Intent intent);
protected abstract void onComplete(); protected abstract void onComplete();
@Override @Override

View File

@ -35,6 +35,9 @@
<!--<module name="ParameterNumber" />--> <!--<module name="ParameterNumber" />-->
<module name="Indentation" /> <module name="Indentation" />
<module name="EmptyLineSeparator">
<property name="allowNoEmptyLineBetweenFields" value="true" />
</module>
<module name="EmptyForIteratorPad" /> <module name="EmptyForIteratorPad" />
<module name="GenericWhitespace" /> <module name="GenericWhitespace" />