From 688142c83ea61402d8111e97c0c3937aedb5a4f3 Mon Sep 17 00:00:00 2001
From: Peter Serwylo <peter@ivt.com.au>
Date: Sun, 28 Apr 2013 18:48:22 +1000
Subject: [PATCH 1/4] bede's changes for adding permissions to app details.

---
 res/layout/appinfo.xml                | 14 +++++++++
 res/values/strings.xml                |  3 ++
 res/xml/preferences.xml               |  1 +
 src/org/fdroid/fdroid/AppDetails.java | 17 +++++++++++
 src/org/fdroid/fdroid/Permission.java | 42 +++++++++++++++++++++++++++
 5 files changed, 77 insertions(+)
 create mode 100644 src/org/fdroid/fdroid/Permission.java

diff --git a/res/layout/appinfo.xml b/res/layout/appinfo.xml
index 9fbc5ac81..90bf38fcc 100644
--- a/res/layout/appinfo.xml
+++ b/res/layout/appinfo.xml
@@ -28,5 +28,19 @@
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
         android:singleLine="false" />
+    
+    <TextView
+        android:id="@+id/permissions"
+        android:layout_width="fill_parent"
+        android:layout_height="wrap_content"
+        android:singleLine="true"
+        android:textSize="14sp"
+        android:text="@string/permissions" />
+    
+        <TextView
+        android:id="@+id/permissions_list"
+        android:layout_width="fill_parent"
+        android:layout_height="wrap_content"
+        android:singleLine="false" />
 
 </LinearLayout>
diff --git a/res/values/strings.xml b/res/values/strings.xml
index 3a064405c..b759aeed2 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -163,5 +163,8 @@
     <string name="status_processing_xml">Processing application\n%2$d of %3$d from\n%1$s</string>
     <string name="status_connecting_to_repo">Connecting to\n%1$s</string>
     <string name="status_checking_compatibility">Checking all apps compatibility with your device…</string>
+    <string name="permissions">Permissions</string>
+    <string name="showPermissions">Show permissions</string>
+    <string name="showPermissions_long">Display a list of permissions an app needs</string>
 
 </resources>
diff --git a/res/xml/preferences.xml b/res/xml/preferences.xml
index 2935561de..d99d4e0af 100644
--- a/res/xml/preferences.xml
+++ b/res/xml/preferences.xml
@@ -53,6 +53,7 @@
 		<CheckBoxPreference android:title="@string/ignoreTouch"
 			android:defaultValue="false" android:summary="@string/ignoreTouch_long"
 			android:key="ignoreTouchscreen" />
+		<CheckBoxPreference android:key="showPermissions" android:summary="@string/showPermissions_long" android:title="@string/showPermissions" android:defaultValue="true"/>
 			</PreferenceCategory>
 	<PreferenceCategory android:title="@string/maintenance">
 		<Preference android:title="@string/reset" android:summary="@string/clear_all_cached_data"
diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java
index 624a32cc6..a1701bddc 100644
--- a/src/org/fdroid/fdroid/AppDetails.java
+++ b/src/org/fdroid/fdroid/AppDetails.java
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2010-12  Ciaran Gultnieks, ciaran@ciarang.com
+ * Copyright (C) 2013 Stefan Völkel, bd@bc-bd.org
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -25,6 +26,7 @@ import java.util.List;
 
 import android.support.v4.view.MenuItemCompat;
 import org.fdroid.fdroid.compat.MenuManager;
+import org.fdroid.fdroid.DB.CommaSeparatedList;
 import org.xml.sax.XMLReader;
 
 import android.app.AlertDialog;
@@ -205,6 +207,7 @@ public class AppDetails extends ListActivity {
 
     private boolean pref_cacheDownloaded;
     private boolean pref_expert;
+    private boolean pref_permissions;
     private boolean resetRequired;
 
     // The signature of the installed version.
@@ -220,6 +223,7 @@ public class AppDetails extends ListActivity {
                 .getDefaultSharedPreferences(getBaseContext());
         pref_cacheDownloaded = prefs.getBoolean("cacheDownloaded", false);
         pref_expert = prefs.getBoolean("expert", false);
+        pref_permissions = prefs.getBoolean("showPermissions", true);
         AppDetails old = (AppDetails) getLastNonConfigurationInstance();
         if (old != null) {
             copyState(old);
@@ -434,6 +438,19 @@ public class AppDetails extends ListActivity {
             tv.setVisibility(View.GONE);
         }
 
+        tv = (TextView) infoView.findViewById(R.id.permissions_list);
+        if (pref_permissions) {
+            CommaSeparatedList permissions = app.apks.get(0).detail_permissions;
+            if (null != permissions)
+                tv.setText(permissions.toString());
+            else {
+                tv.setText("NONE");
+            }
+        } else {
+            tv.setVisibility(View.GONE);
+            tv = (TextView) infoView.findViewById(R.id.permissions);
+            tv.setVisibility(View.GONE);
+        }
     }
 
     @Override
diff --git a/src/org/fdroid/fdroid/Permission.java b/src/org/fdroid/fdroid/Permission.java
new file mode 100644
index 000000000..1ab88837b
--- /dev/null
+++ b/src/org/fdroid/fdroid/Permission.java
@@ -0,0 +1,42 @@
+package org.fdroid.fdroid;
+
+import android.content.Context;
+import android.content.pm.PackageManager;
+import android.content.pm.PermissionInfo;
+import android.graphics.drawable.Drawable;
+
+public class Permission {
+
+    private final PackageManager packageManager;
+    private final PermissionInfo permissionInfo;
+
+    public Permission(Context context, String permission)
+            throws PackageManager.NameNotFoundException {
+        this.packageManager = context.getPackageManager();
+        this.permissionInfo = this.packageManager.getPermissionInfo(
+                fdroidToAndroid(permission), PackageManager.GET_META_DATA);
+    }
+
+    /**
+     * It appears that all of the permissions in android.Manifest.permissions
+     * are prefixed with "android.permission." and then the constant name.
+     * FDroid just includes the constant name in the apk list, so we prefix it
+     * with "android.permission."
+     */
+    private static String fdroidToAndroid(String permission) {
+        return "android.permission." + permission;
+    }
+
+    public CharSequence getName() {
+        return this.permissionInfo.loadLabel(this.packageManager);
+    }
+
+    public CharSequence getDescription() {
+        return this.permissionInfo.loadDescription(this.packageManager);
+    }
+
+    public Drawable getIcon() {
+        return this.permissionInfo.loadIcon(this.packageManager);
+    }
+
+}

From 7849182f9871c81ce77d2c463fe478c7a99862d0 Mon Sep 17 00:00:00 2001
From: Peter Serwylo <peter@ivt.com.au>
Date: Sun, 28 Apr 2013 18:52:26 +1000
Subject: [PATCH 2/4] i18n permissions.

---
 res/layout/appinfo.xml                |  3 ++-
 src/org/fdroid/fdroid/AppDetails.java | 26 +++++++++++++++++++++-----
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/res/layout/appinfo.xml b/res/layout/appinfo.xml
index 90bf38fcc..b14d133e3 100644
--- a/res/layout/appinfo.xml
+++ b/res/layout/appinfo.xml
@@ -35,9 +35,10 @@
         android:layout_height="wrap_content"
         android:singleLine="true"
         android:textSize="14sp"
+        android:textStyle="bold"
         android:text="@string/permissions" />
     
-        <TextView
+    <TextView
         android:id="@+id/permissions_list"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java
index a1701bddc..f9548a6c2 100644
--- a/src/org/fdroid/fdroid/AppDetails.java
+++ b/src/org/fdroid/fdroid/AppDetails.java
@@ -22,8 +22,10 @@ package org.fdroid.fdroid;
 import java.io.File;
 import java.security.NoSuchAlgorithmException;
 import java.util.ArrayList;
+import java.util.Iterator;
 import java.util.List;
 
+import android.content.pm.PermissionInfo;
 import android.support.v4.view.MenuItemCompat;
 import org.fdroid.fdroid.compat.MenuManager;
 import org.fdroid.fdroid.DB.CommaSeparatedList;
@@ -223,7 +225,7 @@ public class AppDetails extends ListActivity {
                 .getDefaultSharedPreferences(getBaseContext());
         pref_cacheDownloaded = prefs.getBoolean("cacheDownloaded", false);
         pref_expert = prefs.getBoolean("expert", false);
-        pref_permissions = prefs.getBoolean("showPermissions", true);
+        pref_permissions = prefs.getBoolean("showPermissions", false);
         AppDetails old = (AppDetails) getLastNonConfigurationInstance();
         if (old != null) {
             copyState(old);
@@ -440,10 +442,24 @@ public class AppDetails extends ListActivity {
 
         tv = (TextView) infoView.findViewById(R.id.permissions_list);
         if (pref_permissions) {
-            CommaSeparatedList permissions = app.apks.get(0).detail_permissions;
-            if (null != permissions)
-                tv.setText(permissions.toString());
-            else {
+            Iterator<String> permissions = app.apks.get(0).detail_permissions.iterator();
+            if (null != permissions && permissions.hasNext()) {
+                StringBuilder sb = new StringBuilder();
+                while(permissions.hasNext()) {
+                    String permissionName = permissions.next();
+                    try {
+                        Permission permission = new Permission(this, permissionName);
+                        sb.append(permission.getName());
+                        if (permissions.hasNext()) {
+                            sb.append('\n');
+                        }
+                    } catch (NameNotFoundException e) {
+                        Log.d( "FDroid",
+                                "Can't find permsission '" + permissionName + "'");
+                    }
+                }
+                tv.setText(sb.toString());
+            } else {
                 tv.setText("NONE");
             }
         } else {

From 8c41f18a1bfe0ad7831620af25ea2c14eeb533da Mon Sep 17 00:00:00 2001
From: Peter Serwylo <peter@ivt.com.au>
Date: Sun, 28 Apr 2013 19:57:12 +1000
Subject: [PATCH 3/4] Change permissions string to include version number of
 latest.

---
 res/layout/appinfo.xml                | 3 +--
 res/values/strings.xml                | 2 +-
 src/org/fdroid/fdroid/AppDetails.java | 3 +++
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/res/layout/appinfo.xml b/res/layout/appinfo.xml
index b14d133e3..6c86329d0 100644
--- a/res/layout/appinfo.xml
+++ b/res/layout/appinfo.xml
@@ -35,8 +35,7 @@
         android:layout_height="wrap_content"
         android:singleLine="true"
         android:textSize="14sp"
-        android:textStyle="bold"
-        android:text="@string/permissions" />
+        android:textStyle="bold" />
     
     <TextView
         android:id="@+id/permissions_list"
diff --git a/res/values/strings.xml b/res/values/strings.xml
index b759aeed2..b870c0099 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -163,7 +163,7 @@
     <string name="status_processing_xml">Processing application\n%2$d of %3$d from\n%1$s</string>
     <string name="status_connecting_to_repo">Connecting to\n%1$s</string>
     <string name="status_checking_compatibility">Checking all apps compatibility with your device…</string>
-    <string name="permissions">Permissions</string>
+    <string name="permissions">Permissions for v%s</string>
     <string name="showPermissions">Show permissions</string>
     <string name="showPermissions_long">Display a list of permissions an app needs</string>
 
diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java
index f9548a6c2..d8a2bad32 100644
--- a/src/org/fdroid/fdroid/AppDetails.java
+++ b/src/org/fdroid/fdroid/AppDetails.java
@@ -462,6 +462,9 @@ public class AppDetails extends ListActivity {
             } else {
                 tv.setText("NONE");
             }
+            tv = (TextView) infoView.findViewById(R.id.permissions);
+            tv.setText(getResources().getString(
+                    R.string.permissions, app.apks.get(0).version));
         } else {
             tv.setVisibility(View.GONE);
             tv = (TextView) infoView.findViewById(R.id.permissions);

From bc791f2338e0fc7c7168dc3b7a08ef7cb08c97a4 Mon Sep 17 00:00:00 2001
From: Peter Serwylo <peter@serwylo.com>
Date: Mon, 29 Apr 2013 10:38:27 +1000
Subject: [PATCH 4/4] Fix null pointer from detail_permissions

---
 src/org/fdroid/fdroid/AppDetails.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java
index d8a2bad32..e4548f4de 100644
--- a/src/org/fdroid/fdroid/AppDetails.java
+++ b/src/org/fdroid/fdroid/AppDetails.java
@@ -442,7 +442,8 @@ public class AppDetails extends ListActivity {
 
         tv = (TextView) infoView.findViewById(R.id.permissions_list);
         if (pref_permissions) {
-            Iterator<String> permissions = app.apks.get(0).detail_permissions.iterator();
+            CommaSeparatedList permsList = app.apks.get(0).detail_permissions;
+            Iterator<String> permissions = permsList != null ? permsList.iterator() : null;
             if (null != permissions && permissions.hasNext()) {
                 StringBuilder sb = new StringBuilder();
                 while(permissions.hasNext()) {