Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

checkstyle: enable OneTopLevelClass

Browse Source 
The only remaining error was ClipboardCompat, which was unnecessarily
exposing three top-level classes. Make the two implementation classes be
nested, private and static.
This commit is contained in:
Daniel Martí 2016-05-05 11:02:26 +01:00
parent 6311ad5c6b
commit 78af79cd4f
2 changed files with 26 additions and 27 deletions
app/src/main/java/org/fdroid/fdroid/compat
ClipboardCompat.java
config/checkstyle
checkstyle.xml

11
app/src/main/java/org/fdroid/fdroid/compat/ClipboardCompat.java

@ -17,10 +17,8 @@ public abstract class ClipboardCompat {
return new OldClipboard(); return new OldClipboard();
} }
} @TargetApi(11)
private static class HoneycombClipboard extends ClipboardCompat {
@TargetApi(11)
class HoneycombClipboard extends ClipboardCompat {
private final ClipboardManager manager; private final ClipboardManager manager;
@ -39,12 +37,13 @@ class HoneycombClipboard extends ClipboardCompat {
} }
return text != null ? text.toString() : null; return text != null ? text.toString() : null;
} }
} }
class OldClipboard extends ClipboardCompat { private static class OldClipboard extends ClipboardCompat {
@Override @Override
public String getText() { public String getText() {
return null; return null;
} }
}
} }

2
config/checkstyle/checkstyle.xml

@ -62,7 +62,7 @@
</module> </module>
<module name="NoLineWrap"/> <module name="NoLineWrap"/>
<!--<module name="OneTopLevelClass" />--> <module name="OneTopLevelClass" />
<module name="OneStatementPerLine" /> <module name="OneStatementPerLine" />
<module name="EmptyBlock"> <module name="EmptyBlock">