From dfca502ac4a7c4527cdb237044c28c34a9e03087 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 25 Jun 2020 10:46:32 +0200 Subject: [PATCH 1/3] use https://f-droid.org/packages/ instead of https://f-droid.org/app This avoids a redirect. Both are supported in the IntentFilters. --- .../main/java/org/fdroid/fdroid/views/AppDetailsActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsActivity.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsActivity.java index 94008a507..3d89b06ba 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsActivity.java +++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsActivity.java @@ -262,7 +262,7 @@ public class AppDetailsActivity extends AppCompatActivity shareIntent.setType("text/plain"); shareIntent.putExtra(Intent.EXTRA_SUBJECT, app.name); shareIntent.putExtra(Intent.EXTRA_TEXT, app.name + " (" + app.summary - + ") - https://f-droid.org/app/" + app.packageName); + + ") - https://f-droid.org/packages/" + app.packageName); boolean showNearbyItem = app.isInstalled(getApplicationContext()) && bluetoothAdapter != null; CoordinatorLayout coordinatorLayout = (CoordinatorLayout) findViewById(R.id.rootCoordinator); From 757476dc9b7805d8ea999261501218b4022af303 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 25 Jun 2020 10:47:47 +0200 Subject: [PATCH 2/3] use canonical download URL: https://f-droid.org/F-Droid.apk fdroid-website@6be403585352126b04e5c72623ef5852cceb2502 fdroid-website!536 --- .../full/java/org/fdroid/fdroid/nearby/LocalRepoManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/full/java/org/fdroid/fdroid/nearby/LocalRepoManager.java b/app/src/full/java/org/fdroid/fdroid/nearby/LocalRepoManager.java index 336e2db0b..172c6450f 100644 --- a/app/src/full/java/org/fdroid/fdroid/nearby/LocalRepoManager.java +++ b/app/src/full/java/org/fdroid/fdroid/nearby/LocalRepoManager.java @@ -124,7 +124,7 @@ public final class LocalRepoManager { private String writeFdroidApkToWebroot() { ApplicationInfo appInfo; - String fdroidClientURL = "https://f-droid.org/FDroid.apk"; + String fdroidClientURL = "https://f-droid.org/F-Droid.apk"; try { appInfo = pm.getApplicationInfo(fdroidPackageName, PackageManager.GET_META_DATA); From 864453bb5d65b8de53219c361b9627ddb1d0d741 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 25 Jun 2020 12:49:55 +0200 Subject: [PATCH 3/3] autoVerify="false" on all IntentFilters for HTTP/HTTPS #2004 The autoVerify function seems to require that the app only declare domain names in the IntentFilters that are set up with the "site association" files. For F-Droid to support the verified app link, it would have to stop matching play.google.com, amazon.com, etc. This autoVerify function also triggers DNS lookups at the system level, which might not be forwarded over Tor, in certain scenarios. So this just disables the whole feature. https://developer.android.com/training/app-links/verify-site-associations --- app/src/main/AndroidManifest.xml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 2a9a29b15..68c59b44f 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -301,7 +301,7 @@ - + @@ -319,7 +319,7 @@ - + @@ -346,7 +346,7 @@ - + @@ -367,7 +367,7 @@ - + @@ -401,7 +401,7 @@ - + @@ -439,7 +439,7 @@ This filter supports HTTP and HTTPS schemes. There is an additional filter for fdroidrepo:// and fdroidrepos:// --> - +