From 6f43d4eb18f5f779f394deadfb2d3bff8d2b50ad Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 24 Feb 2017 21:19:17 +0100 Subject: [PATCH] make checkstyle happy with instance variable names [ant:checkstyle] [ERROR] /export/share/code/fdroid/client/app/src/main/java/com/geecko/QuickLyric/view/AppCompatListPreference.java:35:29: Name 'mDialog' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. [MemberName] Introduced in 79ecffc91c8856e7ceb6a65441d19a6272195426 --- .../QuickLyric/view/AppCompatListPreference.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/com/geecko/QuickLyric/view/AppCompatListPreference.java b/app/src/main/java/com/geecko/QuickLyric/view/AppCompatListPreference.java index e8b3b08f7..507f37755 100644 --- a/app/src/main/java/com/geecko/QuickLyric/view/AppCompatListPreference.java +++ b/app/src/main/java/com/geecko/QuickLyric/view/AppCompatListPreference.java @@ -32,7 +32,7 @@ import java.lang.reflect.Method; public class AppCompatListPreference extends ListPreference { - private AppCompatDialog mDialog; + private AppCompatDialog appCompatDialog; public AppCompatListPreference(Context context) { super(context); @@ -44,7 +44,7 @@ public class AppCompatListPreference extends ListPreference { @Override public AppCompatDialog getDialog() { - return mDialog; + return appCompatDialog; } @Override @@ -82,19 +82,19 @@ public class AppCompatListPreference extends ListPreference { e.printStackTrace(); } - mDialog = builder.create(); + appCompatDialog = builder.create(); if (state != null) { - mDialog.onRestoreInstanceState(state); + appCompatDialog.onRestoreInstanceState(state); } - mDialog.show(); + appCompatDialog.show(); } @Override public void onActivityDestroy() { super.onActivityDestroy(); - if (mDialog != null && mDialog.isShowing() && - mDialog.getWindow() != null && mDialog.getWindow().getWindowManager() != null) { - mDialog.dismiss(); + if (appCompatDialog != null && appCompatDialog.isShowing() && + appCompatDialog.getWindow() != null && appCompatDialog.getWindow().getWindowManager() != null) { + appCompatDialog.dismiss(); } } } \ No newline at end of file