Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid NPE in normalizeUrl

Browse Source 
Found it when trying to add a repo manually:

E/AndroidRuntime(30549): java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.String.replaceAll(java.lang.String, java.lang.String)' on a null object reference
E/AndroidRuntime(30549):        at org.fdroid.fdroid.views.ManageReposActivity$AddRepo.normalizeUrl(ManageReposActivity.java:547)
E/AndroidRuntime(30549):        at org.fdroid.fdroid.views.ManageReposActivity$AddRepo.validateRepoDetails(ManageReposActivity.java:358)
E/AndroidRuntime(30549):        at org.fdroid.fdroid.views.ManageReposActivity$AddRepo.access$700(ManageReposActivity.java:218)
E/AndroidRuntime(30549):        at org.fdroid.fdroid.views.ManageReposActivity$AddRepo$4.afterTextChanged(ManageReposActivity.java:342)
E/AndroidRuntime(30549):        at android.widget.TextView.sendAfterTextChanged(TextView.java:7698)
This commit is contained in:
Daniel Martí 2015-09-23 22:17:23 -07:00
parent 55f467e8ba
commit 6eddfb8b97
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
F-Droid/src/org/fdroid/fdroid/views/ManageReposActivity.java
View File

@ -538,6 +538,9 @@ public class ManageReposActivity extends ActionBarActivity {
* slashes in the path and replaces them with one. Finally, it removes trailing slashes. * slashes in the path and replaces them with one. Finally, it removes trailing slashes.
*/ */
private String normalizeUrl(String urlString) throws URISyntaxException { private String normalizeUrl(String urlString) throws URISyntaxException {
if (urlString == null) {
return null;
}
URI uri = new URI(urlString); URI uri = new URI(urlString);
if (!uri.isAbsolute()) { if (!uri.isAbsolute()) {
throw new URISyntaxException(urlString, "Must provide an absolute URI for repositories"); throw new URISyntaxException(urlString, "Must provide an absolute URI for repositories");