From 6e0ea68bab8dd7358600c92d05cbf0bb5cbb7a7f Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Thu, 1 Dec 2016 11:01:26 +1100 Subject: [PATCH] Push notifyDataSetChanged invocation into adapter. That is probably the place most responsible for knowing if the dataset has changed and broadcasting that fact. --- app/src/main/java/org/fdroid/fdroid/AppDetails2.java | 1 - .../org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/AppDetails2.java b/app/src/main/java/org/fdroid/fdroid/AppDetails2.java index 160b4d492..6c7ab3da3 100644 --- a/app/src/main/java/org/fdroid/fdroid/AppDetails2.java +++ b/app/src/main/java/org/fdroid/fdroid/AppDetails2.java @@ -490,7 +490,6 @@ public class AppDetails2 extends AppCompatActivity implements ShareChooserDialog } AppDetailsRecyclerViewAdapter adapter = (AppDetailsRecyclerViewAdapter)mRecyclerView.getAdapter(); adapter.updateItems(mApp); - adapter.notifyDataSetChanged(); supportInvalidateOptionsMenu(); } }); diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java index 20b3bdf32..947fdb430 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java +++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java @@ -118,6 +118,8 @@ public class AppDetailsRecyclerViewAdapter addItem(VIEWTYPE_LINKS); addItem(VIEWTYPE_PERMISSIONS); addItem(VIEWTYPE_VERSIONS); + + notifyDataSetChanged(); } private void setShowVersions(boolean showVersions) {