Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Close cursors which previously were left dangling.

Browse Source
This commit is contained in:
Peter Serwylo 2016-08-11 23:10:54 +10:00
parent 005d109818
commit 6c1b277cab
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/org/fdroid/fdroid/data/DBHelper.java
View File

@ -786,13 +786,19 @@ class DBHelper extends SQLiteOpenHelper {
}
private static boolean columnExists(SQLiteDatabase db, String table, String column) {
return db.rawQuery("select * from " + table + " limit 0,1", null)
.getColumnIndex(column) != -1;
Cursor cursor = db.rawQuery("select * from " + table + " limit 0,1", null);
boolean exists = cursor.getColumnIndex(column) != -1;
cursor.close();
return exists;
}
private static boolean tableExists(SQLiteDatabase db, String table) {
return db.rawQuery("SELECT name FROM sqlite_master WHERE type = 'table' AND name = ?",
new String[] {table}).getCount() > 0;
Cursor cursor = db.query("sqlite_master", new String[] {"name"},
"type = 'table' AND name = ?", new String[] {table}, null, null, null);
boolean exists = cursor.getCount() > 0;
cursor.close();
return exists;
}
}