Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RepoDetails: hide mirror lists if they are not useful

Browse Source 
e.g., empty lists or the official mirror list just repeating the canonical
URL.
This commit is contained in:
Hans-Christoph Steiner 2019-02-20 22:20:05 +01:00
parent b1569795a2
commit 6a18ba1b85
1 changed files with 24 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
app/src/main/java/org/fdroid/fdroid/views/RepoDetailsActivity.java
View File

@ -336,17 +336,35 @@ public class RepoDetailsActivity extends AppCompatActivity {
} }
private void updateRepoView() { private void updateRepoView() {
TextView officialMirrorsLabel = repoView.findViewById(R.id.label_official_mirrors);
RecyclerView officialMirrorList = repoView.findViewById(R.id.official_mirror_list);
if ((repo.mirrors != null && repo.mirrors.length > 1)
|| (repo.userMirrors != null && repo.userMirrors.length > 0)) {
// don't show this if there is only the canonical URL available, and no other mirrors
officialMirrorsLabel.setVisibility(View.VISIBLE);
officialMirrorList.setVisibility(View.VISIBLE);
} else {
officialMirrorsLabel.setVisibility(View.GONE);
officialMirrorList.setVisibility(View.GONE);
}
TextView userMirrorsLabel = repoView.findViewById(R.id.label_user_mirrors);
RecyclerView userMirrorList = repoView.findViewById(R.id.user_mirror_list);
if (repo.userMirrors != null && repo.userMirrors.length > 0) {
userMirrorsLabel.setVisibility(View.VISIBLE);
userMirrorList.setVisibility(View.VISIBLE);
} else {
userMirrorsLabel.setVisibility(View.GONE);
userMirrorList.setVisibility(View.GONE);
}
if (repo.hasBeenUpdated()) { if (repo.hasBeenUpdated()) {
updateViewForExistingRepo(repoView); updateViewForExistingRepo(repoView);
} else { } else {
updateViewForNewRepo(repoView);
}
}
private void updateViewForNewRepo(View repoView) {
setMultipleViewVisibility(repoView, HIDE_IF_EXISTS, View.VISIBLE); setMultipleViewVisibility(repoView, HIDE_IF_EXISTS, View.VISIBLE);
setMultipleViewVisibility(repoView, SHOW_IF_EXISTS, View.GONE); setMultipleViewVisibility(repoView, SHOW_IF_EXISTS, View.GONE);
} }
}
private void updateViewForExistingRepo(View repoView) { private void updateViewForExistingRepo(View repoView) {
setMultipleViewVisibility(repoView, SHOW_IF_EXISTS, View.VISIBLE); setMultipleViewVisibility(repoView, SHOW_IF_EXISTS, View.VISIBLE);
@ -356,19 +374,6 @@ public class RepoDetailsActivity extends AppCompatActivity {
TextView numApps = repoView.findViewById(R.id.text_num_apps); TextView numApps = repoView.findViewById(R.id.text_num_apps);
TextView lastUpdated = repoView.findViewById(R.id.text_last_update); TextView lastUpdated = repoView.findViewById(R.id.text_last_update);
if (repo.mirrors != null) {
TextView officialMirrorsLabel = repoView.findViewById(R.id.label_official_mirrors);
officialMirrorsLabel.setVisibility(View.VISIBLE);
RecyclerView officialMirrorList = repoView.findViewById(R.id.official_mirror_list);
officialMirrorList.setVisibility(View.VISIBLE);
}
if (repo.userMirrors != null) {
TextView userMirrorsLabel = repoView.findViewById(R.id.label_user_mirrors);
userMirrorsLabel.setVisibility(View.VISIBLE);
RecyclerView userMirrorList = repoView.findViewById(R.id.user_mirror_list);
userMirrorList.setVisibility(View.VISIBLE);
}
name.setText(repo.name); name.setText(repo.name);
int appCount = RepoProvider.Helper.countAppsForRepo(this, repoId); int appCount = RepoProvider.Helper.countAppsForRepo(this, repoId);