From 6957721479ecefacf1e95e12343afc9a9f4fb304 Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Mon, 16 Nov 2015 17:32:46 +1100 Subject: [PATCH] CR: Leave old db update code as it was. This may not have caused any trouble, but the principle behind the old behaviour is that at the point that that was required, the fdroid_repo table had that particular structure. There is a small chance that it _may_ have some unintended consequences when upgrading clients with very old database versions. Probably not, but may as well leave it as is. --- F-Droid/src/org/fdroid/fdroid/data/DBHelper.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/F-Droid/src/org/fdroid/fdroid/data/DBHelper.java b/F-Droid/src/org/fdroid/fdroid/data/DBHelper.java index 3d301f62e..dc8f717e3 100644 --- a/F-Droid/src/org/fdroid/fdroid/data/DBHelper.java +++ b/F-Droid/src/org/fdroid/fdroid/data/DBHelper.java @@ -169,14 +169,12 @@ public class DBHelper extends SQLiteOpenHelper { + "maxage integer not null default 0, " + "version integer not null default 0, " + "lastetag text, " - + "lastUpdated string," - + "username string, password string" - + ");"; + + "lastUpdated string);"; db.execSQL(createTableDdl); String nonIdFields = "address, name, description, inuse, priority, " + - "pubkey, fingerprint, maxage, version, lastetag, lastUpdated, username, password"; + "pubkey, fingerprint, maxage, version, lastetag, lastUpdated"; String insertSql = "INSERT INTO " + TABLE_REPO + "(_id, " + nonIdFields + " ) " +