Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PMD: Enable and obey ImmutableField

Browse Source
This commit is contained in:
Daniel Martí 2016-04-23 16:25:26 +01:00
parent c746a49b15
commit 68db3ae353
5 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/androidTest/java/mock/MockFDroidResources.java
View File

@ -7,7 +7,7 @@ import org.fdroid.fdroid.R;
public class MockFDroidResources extends MockResources { public class MockFDroidResources extends MockResources {
private Context getStringDelegatingContext; private final Context getStringDelegatingContext;
public MockFDroidResources(Context getStringDelegatingContext) { public MockFDroidResources(Context getStringDelegatingContext) {
this.getStringDelegatingContext = getStringDelegatingContext; this.getStringDelegatingContext = getStringDelegatingContext;

2
app/src/androidTest/java/mock/MockInstallablePackageManager.java
View File

@ -10,7 +10,7 @@ import java.util.List;
public class MockInstallablePackageManager extends MockPackageManager { public class MockInstallablePackageManager extends MockPackageManager {
private List<PackageInfo> info = new ArrayList<>(); private final List<PackageInfo> info = new ArrayList<>();
@Override @Override
public List<PackageInfo> getInstalledPackages(int flags) { public List<PackageInfo> getInstalledPackages(int flags) {

2
app/src/main/java/com/google/zxing/encode/QRCodeEncoder.java
View File

@ -37,7 +37,7 @@ public final class QRCodeEncoder {
private static final int WHITE = 0xFFFFFFFF; private static final int WHITE = 0xFFFFFFFF;
private static final int BLACK = 0xFF000000; private static final int BLACK = 0xFF000000;
private int dimension = Integer.MIN_VALUE; private final int dimension;
private String contents; private String contents;
private String displayContents; private String displayContents;
private String title; private String title;

2
app/src/main/java/org/fdroid/fdroid/installer/PrivilegedInstaller.java
View File

@ -76,7 +76,7 @@ public class PrivilegedInstaller extends Installer {
private static final String PRIVILEGED_EXTENSION_SERVICE_INTENT = "org.fdroid.fdroid.privileged.IPrivilegedService"; private static final String PRIVILEGED_EXTENSION_SERVICE_INTENT = "org.fdroid.fdroid.privileged.IPrivilegedService";
public static final String PRIVILEGED_EXTENSION_PACKAGE_NAME = "org.fdroid.fdroid.privileged"; public static final String PRIVILEGED_EXTENSION_PACKAGE_NAME = "org.fdroid.fdroid.privileged";
private Activity mActivity; private final Activity mActivity;
private static final int REQUEST_CONFIRM_PERMS = 0; private static final int REQUEST_CONFIRM_PERMS = 0;

1
config/pmd/rules.xml
View File

@ -25,4 +25,5 @@
<rule ref="rulesets/java/design.xml/NonCaseLabelInSwitchStatement"/> <rule ref="rulesets/java/design.xml/NonCaseLabelInSwitchStatement"/>
<rule ref="rulesets/java/design.xml/EqualsNull"/> <rule ref="rulesets/java/design.xml/EqualsNull"/>
<rule ref="rulesets/java/design.xml/IdempotentOperations"/> <rule ref="rulesets/java/design.xml/IdempotentOperations"/>
<rule ref="rulesets/java/design.xml/ImmutableField"/>
</ruleset> </ruleset>