From 65e2931fe8c7892b1ddd17f813ff6ffced5cb093 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Thu, 12 May 2016 10:40:12 +0100
Subject: [PATCH] PMD: Enable UnnecessaryWrapperObjectCreation

---
 .../java/org/fdroid/fdroid/localrepo/LocalRepoManager.java    | 4 +++-
 config/pmd/rules.xml                                          | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java b/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
index dd358f00b..faccfd992 100644
--- a/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
+++ b/app/src/main/java/org/fdroid/fdroid/localrepo/LocalRepoManager.java
@@ -372,7 +372,9 @@ public final class LocalRepoManager {
             SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
 
             // max age is an EditTextPreference, which is always a String
-            int repoMaxAge = Float.valueOf(prefs.getString("max_repo_age_days", DEFAULT_REPO_MAX_AGE_DAYS)).intValue();
+            // TODO: This pref is probably never being set. Also, why
+            // are we mixing floats and ints?
+            int repoMaxAge = Float.valueOf(prefs.getString("max_repo_age_days", DEFAULT_REPO_MAX_AGE_DAYS)).intValue(); // NOPMD
 
             serializer.startTag("", "repo");
 
diff --git a/config/pmd/rules.xml b/config/pmd/rules.xml
index 6ad35b90e..1ca6078d2 100644
--- a/config/pmd/rules.xml
+++ b/config/pmd/rules.xml
@@ -20,6 +20,7 @@
     <rule ref="rulesets/java/optimizations.xml/PrematureDeclaration"/>
     <rule ref="rulesets/java/optimizations.xml/AddEmptyString"/>
     <rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/>
+    <rule ref="rulesets/java/optimizations.xml/UnnecessaryWrapperObjectCreation"/>
 
     <rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>
     <rule ref="rulesets/java/controversial.xml/UnnecessaryParentheses"/>