From 6545a26e316edf5db9f6c73e296fe6094534b392 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 10 Nov 2016 16:54:27 +0100 Subject: [PATCH] set HTTP User Agent to "F-Droid" First, this is more honest than just using the default since it is saying what the actual software is. Second, it protects identity, since the default User Agent on Android can have a lot of info in it, for example: "Dalvik/2.1.0 (Linux; U; Android 5.1; XT1039 Build/LPBS23.13-17.3-1)" --- app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java b/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java index 3780bfd53..d792ed2b0 100644 --- a/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java +++ b/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java @@ -3,6 +3,7 @@ package org.fdroid.fdroid.net; import com.nostra13.universalimageloader.core.download.BaseImageDownloader; import org.apache.commons.io.FileUtils; +import org.fdroid.fdroid.BuildConfig; import org.fdroid.fdroid.FDroidApp; import org.fdroid.fdroid.Utils; import org.spongycastle.util.encoders.Base64; @@ -116,6 +117,8 @@ public class HttpDownloader extends Downloader { connection = NetCipher.getHttpURLConnection(sourceUrl); } + connection.setRequestProperty("User-Agent", "F-Droid " + BuildConfig.VERSION_NAME); + if (username != null && password != null) { // add authorization header from username / password if set String authString = username + ":" + password;