From 63807a688d484254b2e381367493a961296818c6 Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Thu, 12 May 2016 12:25:25 +1000 Subject: [PATCH] Return app name correctly from `getAppName()`. Due to the earlier refactoring of `getNotificationTitle()` (or something like that) to `getAppName()`, it was still returning `getString(downloading_apk, appName)` instead of just the app name. --- .../org/fdroid/fdroid/installer/InstallManagerService.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java b/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java index 12a20b692..f8ed6a7c3 100644 --- a/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java +++ b/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java @@ -245,13 +245,13 @@ public class InstallManagerService extends Service { App app = ACTIVE_APPS.get(apk.packageName); if (app == null || TextUtils.isEmpty(app.name)) { if (TEMP_HACK_APP_NAMES.containsKey(urlString)) { - return getString(R.string.downloading_apk, TEMP_HACK_APP_NAMES.get(urlString)); + return TEMP_HACK_APP_NAMES.get(urlString); } else { // this is ugly, but its better than nothing as a failsafe - return getString(R.string.downloading_apk, urlString); + return urlString; } } else { - return getString(R.string.downloading_apk, app.name); + return app.name; } }