Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'revertBetaUpdates' into 'master'

Browse Source 
Revert "Prompt for beta updates"

This reverts commit 92f8678b3d2da18ad93bac6af0ae83984cf74714.

I read the logs on IRC and agree that we should revert this for stable.

CC @pserwylo

See merge request !122
This commit is contained in:
Nico Alt 2015-08-22 19:52:13 +00:00
commit 625c306b2f
5 changed files with 1 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
F-Droid/res/values/strings.xml
View File

@ -13,8 +13,6 @@
<string name="cache_downloaded">App cache</string>
<string name="cache_downloaded_on">Keep downloaded .apk files on device</string>
<string name="updates">Updates</string>
<string name="updates_summary">Get updates newer than suggested version</string>
<string name="beta_updates">Beta updates</string>
<string name="other">Other</string>
<string name="last_update_check">Last repo scan: %s</string>
<string name="never">never</string>

5
F-Droid/res/xml/preferences.xml
View File

@ -78,11 +78,6 @@
<CheckBoxPreference android:title="@string/cache_downloaded"
android:defaultValue="false"
android:key="cacheDownloaded" />
<CheckBoxPreference
android:key="betaUpdates"
android:title="@string/beta_updates"
android:summary="@string/updates_summary"
android:defaultValue="false" />
<CheckBoxPreference android:title="@string/expert"
android:defaultValue="false"
android:key="expert" />

8
F-Droid/src/org/fdroid/fdroid/FDroidApp.java
View File

@ -187,14 +187,6 @@ public class FDroidApp extends Application {
}
});
final Context context = this;
Preferences.get().registerBetaUpdatesChangeListener(new Preferences.ChangeListener() {
@Override
public void onPreferenceChange() {
AppProvider.Helper.calcDetailsFromIndex(context);
}
});
// Clear cached apk files. We used to just remove them after they'd
// been installed, but this causes problems for proprietary gapps
// users since the introduction of verification (on pre-4.2 Android),

19
F-Droid/src/org/fdroid/fdroid/Preferences.java
View File

@ -47,7 +47,6 @@ public class Preferences implements SharedPreferences.OnSharedPreferenceChangeLi
public static final String PREF_COMPACT_LAYOUT = "compactlayout";
public static final String PREF_IGN_TOUCH = "ignoreTouchscreen";
public static final String PREF_CACHE_APK = "cacheDownloaded";
public static final String PREF_BETA_UPDATES = "betaUpdates";
public static final String PREF_EXPERT = "expert";
public static final String PREF_UPD_LAST = "lastUpdateCheck";
public static final String PREF_SYSTEM_INSTALLER = "systemInstaller";
@ -69,7 +68,6 @@ public class Preferences implements SharedPreferences.OnSharedPreferenceChangeLi
private static final boolean DEFAULT_SYSTEM_INSTALLER = false;
private static final boolean DEFAULT_LOCAL_REPO_BONJOUR = true;
private static final boolean DEFAULT_CACHE_APK = false;
private static final boolean DEFAULT_BETA_UPDATES = false;
private static final boolean DEFAULT_LOCAL_REPO_HTTPS = false;
private static final boolean DEFAULT_INCOMP_VER = false;
private static final boolean DEFAULT_EXPERT = false;
@ -92,7 +90,6 @@ public class Preferences implements SharedPreferences.OnSharedPreferenceChangeLi
private final List<ChangeListener> localRepoBonjourListeners = new ArrayList<>();
private final List<ChangeListener> localRepoNameListeners = new ArrayList<>();
private final List<ChangeListener> localRepoHttpsListeners = new ArrayList<>();
private final List<ChangeListener> betaUpdatesListeners = new ArrayList<>();
private boolean isInitialized(String key) {
return initialized.containsKey(key) && initialized.get(key);
@ -138,10 +135,6 @@ public class Preferences implements SharedPreferences.OnSharedPreferenceChangeLi
return preferences.getBoolean(PREF_CACHE_APK, DEFAULT_CACHE_APK);
}
public boolean getBetaUpdates() {
return preferences.getBoolean(PREF_BETA_UPDATES, DEFAULT_BETA_UPDATES);
}
public boolean showIncompatibleVersions() {
return preferences.getBoolean(PREF_INCOMP_VER, DEFAULT_INCOMP_VER);
}
@ -248,14 +241,6 @@ public class Preferences implements SharedPreferences.OnSharedPreferenceChangeLi
filterAppsRequiringRootListeners.remove(listener);
}
public void registerBetaUpdatesChangeListener(ChangeListener listener) {
betaUpdatesListeners.add(listener);
}
public void unregisterBetaUpdatesChangeListener(ChangeListener listener) {
betaUpdatesListeners.remove(listener);
}
@Override
public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) {
Utils.DebugLog(TAG, "Invalidating preference '" + key + "'.");
@ -291,10 +276,6 @@ public class Preferences implements SharedPreferences.OnSharedPreferenceChangeLi
for (ChangeListener listener : localRepoHttpsListeners) {
listener.onPreferenceChange();
}
case PREF_BETA_UPDATES:
for (ChangeListener listener : betaUpdatesListeners) {
listener.onPreferenceChange();
}
break;
}
}

4
F-Droid/src/org/fdroid/fdroid/data/AppProvider.java
View File

@ -851,8 +851,6 @@ public class AppProvider extends FDroidProvider {
final String apk = DBHelper.TABLE_APK;
final String app = DBHelper.TABLE_APP;
final boolean betaUpdates = Preferences.get().getBetaUpdates();
String restrictToStable = betaUpdates ? "" : ( apk + ".vercode <= " + app + ".upstreamVercode AND " );
String updateSql =
"UPDATE " + app +
" SET suggestedVercode = ( " +
@ -860,7 +858,7 @@ public class AppProvider extends FDroidProvider {
" FROM " + apk +
" WHERE " +
app + ".id = " + apk + ".id AND " +
restrictToStable +
apk + ".vercode <= " + app + ".upstreamVercode AND " +
" ( " + app + ".compatible = 0 OR " + apk + ".compatible = 1 ) ) " +
" WHERE upstreamVercode > 0 ";