From 60f02c0181c333b3735cfe5b75ffe3823212a3c2 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 16 Jul 2015 23:02:11 -0700 Subject: [PATCH] in Downloader, instance vars that are set in constructor should be final --- F-Droid/src/org/fdroid/fdroid/net/Downloader.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/F-Droid/src/org/fdroid/fdroid/net/Downloader.java b/F-Droid/src/org/fdroid/fdroid/net/Downloader.java index fa064a3d0..000e26576 100644 --- a/F-Droid/src/org/fdroid/fdroid/net/Downloader.java +++ b/F-Droid/src/org/fdroid/fdroid/net/Downloader.java @@ -26,12 +26,12 @@ public abstract class Downloader { public static final String EXTRA_BYTES_READ = "extraBytesRead"; public static final String EXTRA_TOTAL_BYTES = "extraTotalBytes"; - private OutputStream outputStream; + private final OutputStream outputStream; - private LocalBroadcastManager localBroadcastManager; + private final LocalBroadcastManager localBroadcastManager; private final File outputFile; - protected URL sourceUrl; + protected final URL sourceUrl; protected String cacheTag = null; public abstract InputStream getInputStream() throws IOException;