Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove unneeded method, it is only called once by the method above

Browse Source
This commit is contained in:
Hans-Christoph Steiner 2018-07-20 23:24:23 +02:00
parent 8feb735140
commit 5e75bc060c
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/src/main/java/org/fdroid/fdroid/views/apps/AppListItemController.java
View File

@ -56,7 +56,7 @@ import java.util.Iterator;
* </ul> * </ul>
* <p> * <p>
* The state of the UI is defined in a dumb {@link AppListItemState} class, then applied to the UI * The state of the UI is defined in a dumb {@link AppListItemState} class, then applied to the UI
* in the {@link #refreshView(App, AppUpdateStatus)} method. * in the {@link #updateAppStatus(App, AppUpdateStatus)} method.
*/ */
public abstract class AppListItemController extends RecyclerView.ViewHolder { public abstract class AppListItemController extends RecyclerView.ViewHolder {
@ -220,15 +220,10 @@ public abstract class AppListItemController extends RecyclerView.ViewHolder {
} }
/** /**
* Updates both the progress bar and the circular install button (which shows progress around the outside of * Updates both the progress bar and the circular install button (which
* the circle). Also updates the app label to indicate that the app is being downloaded. * shows progress around the outside of the circle). Also updates the app
*/ * label to indicate that the app is being downloaded.
private void updateAppStatus(@NonNull App app, @Nullable AppUpdateStatus status) { * <p>
currentStatus = status;
refreshView(app, status);
}
/**
* Queries the current state via {@link #getCurrentViewState(App, AppUpdateStatus)} * Queries the current state via {@link #getCurrentViewState(App, AppUpdateStatus)}
* and then updates the relevant widgets depending on that state. * and then updates the relevant widgets depending on that state.
* <p> * <p>
@ -238,7 +233,8 @@ public abstract class AppListItemController extends RecyclerView.ViewHolder {
* @see AppListItemState * @see AppListItemState
* @see #getCurrentViewState(App, AppUpdateStatus) * @see #getCurrentViewState(App, AppUpdateStatus)
*/ */
private void refreshView(@NonNull App app, @Nullable AppUpdateStatus appStatus) { private void updateAppStatus(@NonNull App app, @Nullable AppUpdateStatus appStatus) {
currentStatus = appStatus;
AppListItemState viewState = getCurrentViewState(app, appStatus); AppListItemState viewState = getCurrentViewState(app, appStatus);