From 16c34a95d3aa30ae3ae3893635547516d9ef55aa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Thu, 20 Feb 2014 14:15:50 +0100
Subject: [PATCH] First attempt at supporting RTL

Following the Android 4.2 changes, which explain how to add native support for
RTL, I've replaced Right for End and Left for Start. Enabling RTL to see the
results.
---
 AndroidManifest.xml              |  2 +-
 res/layout-land/appdetails.xml   |  4 ++--
 res/layout/about.xml             | 10 +++++-----
 res/layout/addrepo.xml           |  2 +-
 res/layout/apklistitem.xml       | 12 ++++++------
 res/layout/appdetails.xml        | 18 +++++++++---------
 res/layout/applistitem.xml       | 22 +++++++++++-----------
 res/layout/repo_item.xml         |  6 +++---
 res/layout/repodetails.xml       | 16 ++++++++--------
 res/layout/repodiscoveryitem.xml |  4 ++--
 res/layout/repodiscoverylist.xml |  4 ++--
 res/layout/searchresults.xml     |  4 ++--
 12 files changed, 52 insertions(+), 52 deletions(-)

diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index fa6e046f1..fb848a3aa 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -44,7 +44,7 @@
         android:label="@string/app_name"
         android:allowBackup="true"
         android:theme="@style/AppThemeDark"
-        android:supportsRtl="false" >
+        android:supportsRtl="true" >
 
         <provider
             android:authorities="org.fdroid.fdroid.data.AppProvider"
diff --git a/res/layout-land/appdetails.xml b/res/layout-land/appdetails.xml
index 53c06af43..03ab9b911 100644
--- a/res/layout-land/appdetails.xml
+++ b/res/layout-land/appdetails.xml
@@ -15,7 +15,7 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:padding="5dp"
-            android:layout_marginRight="4dp"
+            android:layout_marginEnd="4dp"
             android:orientation="vertical" >
 
 			<TextView
@@ -44,7 +44,7 @@
 					android:layout_width="fill_parent"
 					android:layout_height="wrap_content"
 					android:padding="4dp"
-					android:layout_toRightOf="@id/icon"
+					android:layout_toEndOf="@id/icon"
 					android:orientation="vertical" >
 
 					<TextView
diff --git a/res/layout/about.xml b/res/layout/about.xml
index 6c2e935a3..7a3837d06 100644
--- a/res/layout/about.xml
+++ b/res/layout/about.xml
@@ -2,8 +2,8 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
 	android:layout_width="fill_parent"
 	android:layout_height="fill_parent"
-	android:paddingLeft="8dp"
-	android:paddingRight="8dp"
+	android:paddingStart="8dp"
+	android:paddingEnd="8dp"
 	android:paddingTop="6dp"
 	android:paddingBottom="6dp"
 	android:baselineAligned="false"
@@ -20,7 +20,7 @@
 			android:layout_height="wrap_content" />
 
 		<TextView android:id="@+id/version"
-			android:paddingLeft="5dp"
+			android:paddingStart="5dp"
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content" />
 
@@ -38,7 +38,7 @@
 
 		<TextView android:id="@+id/sitec"
 			android:text="@string/about_sitec"
-			android:paddingLeft="5dp"
+			android:paddingStart="5dp"
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content" />
 
@@ -57,7 +57,7 @@
 
 		<TextView android:id="@+id/mailc"
 			android:text="@string/about_mailc"
-			android:paddingLeft="5dp"
+			android:paddingStart="5dp"
 			android:autoLink="email"
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content" />
diff --git a/res/layout/addrepo.xml b/res/layout/addrepo.xml
index 667bf02fa..4910a3663 100644
--- a/res/layout/addrepo.xml
+++ b/res/layout/addrepo.xml
@@ -36,7 +36,7 @@
         android:id="@+id/overwrite_message"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:drawableLeft="@android:drawable/ic_dialog_alert"
+        android:drawableStart="@android:drawable/ic_dialog_alert"
         android:drawablePadding="20dp"
         android:padding="20dp"
         android:text="@string/repo_delete_to_overwrite"
diff --git a/res/layout/apklistitem.xml b/res/layout/apklistitem.xml
index 310bbd5bc..4eec65c00 100644
--- a/res/layout/apklistitem.xml
+++ b/res/layout/apklistitem.xml
@@ -30,7 +30,7 @@
 
   <TextView android:id="@+id/buildtype"
 		android:textSize="13sp"
-		android:layout_alignParentRight="true"
+		android:layout_alignParentEnd="true"
 		android:layout_height="wrap_content"
 		android:layout_width="wrap_content"
 		android:layout_marginBottom="4sp" />
@@ -38,7 +38,7 @@
   <TextView android:id="@+id/size"
 		android:textSize="13sp"
 		android:layout_below="@id/buildtype"
-		android:layout_alignParentRight="true"
+		android:layout_alignParentEnd="true"
 		android:layout_height="wrap_content"
 		android:layout_width="wrap_content"
 		android:layout_marginBottom="4sp" />
@@ -46,22 +46,22 @@
   <TextView android:id="@+id/api"
 		android:textSize="13sp"
 		android:layout_below="@id/buildtype"
-		android:layout_toLeftOf="@id/size"
-		android:layout_marginRight="16sp"
+		android:layout_toStartOf="@id/size"
+		android:layout_marginEnd="16sp"
 		android:layout_height="wrap_content"
 		android:layout_width="wrap_content" />
 
   <TextView android:id="@+id/nativecode"
 		android:textSize="13sp"
 		android:layout_below="@id/size"
-		android:layout_alignParentRight="true"
+		android:layout_alignParentEnd="true"
 		android:layout_height="wrap_content"
 		android:layout_width="wrap_content" />
 
   <TextView android:id="@+id/incompatible_reasons"
 		android:textSize="13sp"
 		android:layout_below="@id/added"
-		android:layout_alignParentLeft="true"
+		android:layout_alignParentStart="true"
 		android:layout_height="wrap_content"
 		android:layout_width="wrap_content" />
 
diff --git a/res/layout/appdetails.xml b/res/layout/appdetails.xml
index 9f3fcd070..612cd6512 100644
--- a/res/layout/appdetails.xml
+++ b/res/layout/appdetails.xml
@@ -24,7 +24,7 @@
 			android:layout_width="fill_parent"
 			android:layout_height="wrap_content"
 			android:layout_centerVertical="true"
-			android:layout_toRightOf="@id/icon"
+			android:layout_toEndOf="@id/icon"
 			android:padding="5dp"
 			android:baselineAligned="false"
 			android:orientation="vertical" >
@@ -34,10 +34,10 @@
 				android:layout_width="wrap_content"
 				android:layout_height="wrap_content"
 				android:layout_alignParentTop="true"
-				android:layout_alignParentRight="true"
+				android:layout_alignParentEnd="true"
 				android:singleLine="true"
 				android:ellipsize="end"
-				android:layout_marginLeft="6sp"
+				android:layout_marginStart="6sp"
 				android:textSize="12sp" />
 
 			<TextView
@@ -48,8 +48,8 @@
 				android:ellipsize="end"
 				android:layout_width="wrap_content"
 				android:layout_height="wrap_content"
-				android:layout_alignParentLeft="true"
-				android:layout_toLeftOf="@id/license" />
+				android:layout_alignParentStart="true"
+				android:layout_toStartOf="@id/license" />
 
 			<TextView
 				android:id="@+id/categories"
@@ -57,8 +57,8 @@
 				android:layout_height="wrap_content"
 				android:singleLine="true"
 				android:ellipsize="end"
-				android:layout_alignParentRight="true"
-				android:layout_marginLeft="6sp"
+				android:layout_alignParentEnd="true"
+				android:layout_marginStart="6sp"
 				android:layout_below="@id/title"
 				android:textSize="12sp" />
 
@@ -69,8 +69,8 @@
 				android:singleLine="true"
 				android:ellipsize="end"
 				android:textSize="12sp"
-				android:layout_alignParentLeft="true"
-				android:layout_toLeftOf="@id/categories"
+				android:layout_alignParentStart="true"
+				android:layout_toStartOf="@id/categories"
 				android:layout_below="@id/title" />
 
 
diff --git a/res/layout/applistitem.xml b/res/layout/applistitem.xml
index f01cc5ed6..941fe112a 100644
--- a/res/layout/applistitem.xml
+++ b/res/layout/applistitem.xml
@@ -19,9 +19,9 @@
 		android:orientation="vertical"
 		android:layout_width="fill_parent"
 		android:layout_height="wrap_content"
-		android:paddingLeft="5dp"
-		android:paddingRight="5dp"
-		android:layout_toRightOf="@id/icon"
+		android:paddingStart="5dp"
+		android:paddingEnd="5dp"
+		android:layout_toEndOf="@id/icon"
 		android:layout_centerVertical="true"
 		android:baselineAligned="false" >
 
@@ -31,9 +31,9 @@
 			android:ellipsize="end"
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content"
-			android:layout_marginLeft="6sp"
+			android:layout_marginStart="6sp"
 			android:layout_alignParentTop="true"
-			android:layout_alignParentRight="true" />
+			android:layout_alignParentEnd="true" />
 
 		<TextView android:id="@+id/name"
 			android:textSize="17sp"
@@ -43,8 +43,8 @@
 			android:ellipsize="end"
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content"
-			android:layout_alignParentLeft="true"
-			android:layout_toLeftOf="@id/status" />
+			android:layout_alignParentStart="true"
+			android:layout_toStartOf="@id/status" />
 
 		<TextView android:id="@+id/license"
 			android:textSize="12sp"
@@ -52,9 +52,9 @@
 			android:ellipsize="end"
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content"
-			android:layout_marginLeft="6sp"
+			android:layout_marginStart="6sp"
 			android:layout_below="@id/name"
-			android:layout_alignParentRight="true" />
+			android:layout_alignParentEnd="true" />
 
 		<TextView android:id="@+id/summary"
 			android:textSize="13sp"
@@ -63,8 +63,8 @@
 			android:layout_width="wrap_content"
 			android:layout_height="wrap_content"
 			android:layout_below="@id/name"
-			android:layout_alignParentLeft="true"
-			android:layout_toLeftOf="@id/license" />
+			android:layout_alignParentStart="true"
+			android:layout_toStartOf="@id/license" />
 
 	</RelativeLayout>
 
diff --git a/res/layout/repo_item.xml b/res/layout/repo_item.xml
index 58d983d18..9c0e10951 100644
--- a/res/layout/repo_item.xml
+++ b/res/layout/repo_item.xml
@@ -15,7 +15,7 @@
     <ImageView android:id="@+id/img"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_alignParentLeft="true" />
+        android:layout_alignParentStart="true" />
 
     <TextView android:id="@+id/repo_name"
         android:textSize="21sp"
@@ -24,8 +24,8 @@
         android:ellipsize="marquee"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_toRightOf="@id/img"
-        android:layout_alignParentLeft="true"/>
+        android:layout_toEndOf="@id/img"
+        android:layout_alignParentStart="true"/>
 
     <TextView android:id="@+id/repo_unsigned"
         android:textSize="14sp"
diff --git a/res/layout/repodetails.xml b/res/layout/repodetails.xml
index a221859b3..4168a0ef5 100644
--- a/res/layout/repodetails.xml
+++ b/res/layout/repodetails.xml
@@ -7,8 +7,8 @@
     android:focusable="true"
     android:focusableInTouchMode="true"
     android:paddingTop="@dimen/padding_top"
-    android:paddingLeft="@dimen/padding_side"
-    android:paddingRight="@dimen/padding_side">
+    android:paddingStart="@dimen/padding_side"
+    android:paddingEnd="@dimen/padding_side">
 
     <!-- Editable URL of this repo -->
     <TextView
@@ -16,7 +16,7 @@
         android:layout_height="wrap_content"
         android:id="@+id/label_repo_url"
         android:text="@string/repo_url"
-        android:layout_alignParentLeft="true"
+        android:layout_alignParentStart="true"
         android:layout_alignParentTop="true" />
     <EditText
         android:layout_width="fill_parent"
@@ -32,7 +32,7 @@
         android:id="@+id/label_repo_name"
         android:text="@string/repo_name"
         android:layout_below="@id/input_repo_url"
-        android:layout_alignParentLeft="true"
+        android:layout_alignParentStart="true"
         android:paddingTop="@dimen/form_label_top"/>
     <TextView
         android:layout_width="wrap_content"
@@ -48,7 +48,7 @@
         android:id="@+id/label_description"
         android:text="@string/repo_description"
         android:layout_below="@id/text_repo_name"
-        android:layout_alignParentLeft="true"
+        android:layout_alignParentStart="true"
         android:paddingTop="@dimen/form_label_top"/>
     <TextView
         android:layout_width="wrap_content"
@@ -65,7 +65,7 @@
         android:id="@+id/label_num_apps"
         android:text="@string/repo_num_apps"
         android:layout_below="@id/text_description"
-        android:layout_alignParentLeft="true"
+        android:layout_alignParentStart="true"
         android:paddingTop="@dimen/form_label_top" />
     <TextView
         android:layout_width="wrap_content"
@@ -80,7 +80,7 @@
         android:id="@+id/label_last_update"
         android:text="@string/repo_last_update"
         android:layout_below="@id/text_num_apps"
-        android:layout_alignParentLeft="true"
+        android:layout_alignParentStart="true"
         android:paddingTop="@dimen/form_label_top" />
     <TextView
         android:layout_width="wrap_content"
@@ -95,7 +95,7 @@
         android:id="@+id/label_repo_fingerprint"
         android:text="@string/repo_fingerprint"
         android:layout_below="@id/text_last_update"
-        android:layout_alignParentLeft="true"
+        android:layout_alignParentStart="true"
         android:paddingTop="@dimen/form_label_top" />
     <TextView
         android:layout_width="fill_parent"
diff --git a/res/layout/repodiscoveryitem.xml b/res/layout/repodiscoveryitem.xml
index 53c265df0..b6039dfbd 100644
--- a/res/layout/repodiscoveryitem.xml
+++ b/res/layout/repodiscoveryitem.xml
@@ -8,7 +8,7 @@
           android:layout_width="wrap_content"
           android:layout_height="wrap_content"
           android:maxLines="1"
-          android:paddingLeft="8sp"
+          android:paddingStart="8sp"
           android:text="Discovered Repo Name"
           android:textSize="16sp"
           android:textStyle="bold" />
@@ -19,7 +19,7 @@
           android:layout_height="wrap_content"
           android:layout_below="@+id/reposcanitemname"
           android:layout_marginTop="2dp"
-          android:paddingLeft="8sp"
+          android:paddingStart="8sp"
           android:maxLines="1"
           android:text="Repo Address"
           android:textSize="14sp" />
diff --git a/res/layout/repodiscoverylist.xml b/res/layout/repodiscoverylist.xml
index 077636d55..0a8f46052 100644
--- a/res/layout/repodiscoverylist.xml
+++ b/res/layout/repodiscoverylist.xml
@@ -8,7 +8,7 @@
 	    android:layout_width="match_parent"
 	    android:layout_height="50dp"
 	    android:layout_alignParentTop="true"
-	    android:layout_alignParentLeft="true"
+	    android:layout_alignParentStart="true"
 	    android:layout_centerHorizontal="true"
 	    android:paddingTop="8sp" >
 
@@ -18,7 +18,7 @@
 	        android:layout_width="wrap_content"
 	        android:layout_height="wrap_content"
 	        android:layout_gravity="center_horizontal"
-	        android:layout_marginRight="5dp"
+	        android:layout_marginEnd="5dp"
 	        android:indeterminate="true" />
 
 	    <TextView
diff --git a/res/layout/searchresults.xml b/res/layout/searchresults.xml
index b7ddbba70..29ce735c6 100644
--- a/res/layout/searchresults.xml
+++ b/res/layout/searchresults.xml
@@ -2,8 +2,8 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
 	android:layout_width="fill_parent"
 	android:layout_height="fill_parent"
-	android:paddingLeft="2dp"
-	android:paddingRight="2dp"
+	android:paddingStart="2dp"
+	android:paddingEnd="2dp"
 	android:baselineAligned="false"
 	android:orientation="vertical">