From 5736c70dc8b379e15e1d2a41b25875a28c5e47f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Thu, 8 Oct 2015 19:29:04 +0200 Subject: [PATCH] checkstyle: enable and apply FinalClass --- F-Droid/src/org/fdroid/fdroid/AppDetails.java | 2 +- F-Droid/src/org/fdroid/fdroid/Preferences.java | 2 +- F-Droid/src/org/fdroid/fdroid/Utils.java | 2 +- .../src/org/fdroid/fdroid/localrepo/LocalRepoKeyStore.java | 4 ++-- F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoManager.java | 2 +- .../src/org/fdroid/fdroid/localrepo/type/BluetoothSwap.java | 2 +- .../src/org/fdroid/fdroid/net/bluetooth/httpish/Request.java | 3 +-- config/checkstyle/checkstyle.xml | 2 +- 8 files changed, 9 insertions(+), 10 deletions(-) diff --git a/F-Droid/src/org/fdroid/fdroid/AppDetails.java b/F-Droid/src/org/fdroid/fdroid/AppDetails.java index 03fadc0d3..c602e2e23 100644 --- a/F-Droid/src/org/fdroid/fdroid/AppDetails.java +++ b/F-Droid/src/org/fdroid/fdroid/AppDetails.java @@ -704,7 +704,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A startActivity(intent); } - private static class SafeLinkMovementMethod extends LinkMovementMethod { + private static final class SafeLinkMovementMethod extends LinkMovementMethod { private static SafeLinkMovementMethod instance; diff --git a/F-Droid/src/org/fdroid/fdroid/Preferences.java b/F-Droid/src/org/fdroid/fdroid/Preferences.java index 4c7da108f..419724d33 100644 --- a/F-Droid/src/org/fdroid/fdroid/Preferences.java +++ b/F-Droid/src/org/fdroid/fdroid/Preferences.java @@ -21,7 +21,7 @@ import java.util.Random; * accessed via the {@link org.fdroid.fdroid.Preferences#get()} * singleton method. */ -public class Preferences implements SharedPreferences.OnSharedPreferenceChangeListener { +public final class Preferences implements SharedPreferences.OnSharedPreferenceChangeListener { private static final String TAG = "Preferences"; diff --git a/F-Droid/src/org/fdroid/fdroid/Utils.java b/F-Droid/src/org/fdroid/fdroid/Utils.java index c4f306179..615ccb590 100644 --- a/F-Droid/src/org/fdroid/fdroid/Utils.java +++ b/F-Droid/src/org/fdroid/fdroid/Utils.java @@ -421,7 +421,7 @@ public final class Utils { return repoAddress + "/" + apk.apkName.replace(" ", "%20"); } - public static class CommaSeparatedList implements Iterable { + public static final class CommaSeparatedList implements Iterable { private final String value; private CommaSeparatedList(String list) { diff --git a/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoKeyStore.java b/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoKeyStore.java index 321fec8f6..9b40f5d14 100644 --- a/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoKeyStore.java +++ b/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoKeyStore.java @@ -54,7 +54,7 @@ import kellinwood.security.zipsigner.ZipSigner; // TODO Address exception handling in a uniform way throughout -public class LocalRepoKeyStore { +public final class LocalRepoKeyStore { private static final String TAG = "LocalRepoKeyStore"; @@ -333,7 +333,7 @@ public class LocalRepoKeyStore { * for it's chosen server alias. All other operations are deferred to the * wrapped X509KeyManager. */ - private static class KerplappKeyManager implements X509KeyManager { + private static final class KerplappKeyManager implements X509KeyManager { private final X509KeyManager wrapped; private KerplappKeyManager(X509KeyManager wrapped) { diff --git a/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoManager.java b/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoManager.java index 58b64ef9a..8440c5842 100644 --- a/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoManager.java +++ b/F-Droid/src/org/fdroid/fdroid/localrepo/LocalRepoManager.java @@ -62,7 +62,7 @@ import java.util.jar.JarOutputStream; * This class deals specifically with the webroot side of things, ensuring we have a valid index.jar * and the relevant .apk and icon files available. */ -public class LocalRepoManager { +public final class LocalRepoManager { private static final String TAG = "LocalRepoManager"; // For ref, official F-droid repo presently uses a maxage of 14 days diff --git a/F-Droid/src/org/fdroid/fdroid/localrepo/type/BluetoothSwap.java b/F-Droid/src/org/fdroid/fdroid/localrepo/type/BluetoothSwap.java index df1af5b17..d1a860f61 100644 --- a/F-Droid/src/org/fdroid/fdroid/localrepo/type/BluetoothSwap.java +++ b/F-Droid/src/org/fdroid/fdroid/localrepo/type/BluetoothSwap.java @@ -13,7 +13,7 @@ import org.fdroid.fdroid.Utils; import org.fdroid.fdroid.localrepo.SwapService; import org.fdroid.fdroid.net.bluetooth.BluetoothServer; -public class BluetoothSwap extends SwapType { +public final class BluetoothSwap extends SwapType { private static final String TAG = "BluetoothSwap"; public static final String BLUETOOTH_NAME_TAG = "FDroid:"; diff --git a/F-Droid/src/org/fdroid/fdroid/net/bluetooth/httpish/Request.java b/F-Droid/src/org/fdroid/fdroid/net/bluetooth/httpish/Request.java index 420166996..324ee6721 100644 --- a/F-Droid/src/org/fdroid/fdroid/net/bluetooth/httpish/Request.java +++ b/F-Droid/src/org/fdroid/fdroid/net/bluetooth/httpish/Request.java @@ -12,8 +12,7 @@ import java.util.HashMap; import java.util.Locale; import java.util.Map; -public class Request { - +public final class Request { private static final String TAG = "bluetooth.Request"; diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml index 34aba2ddb..d57ce0519 100644 --- a/config/checkstyle/checkstyle.xml +++ b/config/checkstyle/checkstyle.xml @@ -60,7 +60,7 @@ - +