From 56ddbf2056bddd2d635166bec146b3a8bb0eb126 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 28 Mar 2019 19:52:21 +0100 Subject: [PATCH] fix crash on bad values in minSdkVersion java.lang.NumberFormatException: For input string: "@2131034146" at java.lang.Integer.parseInt(Integer.java:615) at java.lang.Integer.parseInt(Integer.java:650) at org.fdroid.fdroid.data.App.getMinTargetMaxSdkVersions(App.java:1092) at org.fdroid.fdroid.data.App.initInstalledApk(App.java:769) at org.fdroid.fdroid.data.App.getInstance(App.java:395) at org.fdroid.fdroid.localrepo.CacheSwapAppsService.onHandleIntent(CacheSwapAppsService.java:77) at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:76) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:193) at android.os.HandlerThread.run(HandlerThread.java:65) --- app/src/main/java/org/fdroid/fdroid/data/App.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/data/App.java b/app/src/main/java/org/fdroid/fdroid/data/App.java index 23bf8af20..c7badbb29 100644 --- a/app/src/main/java/org/fdroid/fdroid/data/App.java +++ b/app/src/main/java/org/fdroid/fdroid/data/App.java @@ -1112,7 +1112,10 @@ public class App extends ValueObject implements Comparable, Parcelable { } eventType = xml.nextToken(); } - } catch (PackageManager.NameNotFoundException | IOException | XmlPullParserException e) { + } catch (PackageManager.NameNotFoundException + | IOException + | XmlPullParserException + | NumberFormatException e) { Log.e(TAG, "Could not get min/max sdk version", e); } if (targetSdkVersion < minSdkVersion) {