Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update summaries via methods, greatly decreasing source lines

Browse Source
This commit is contained in:
Daniel Martí 2014-01-01 02:09:16 +01:00
parent 962521947e
commit 56cb8ccdda
1 changed files with 60 additions and 116 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

176
src/org/fdroid/fdroid/PreferencesActivity.java
View File

@ -65,6 +65,27 @@ public class PreferencesActivity extends PreferenceActivity implements
addPreferencesFromResource(R.xml.preferences); addPreferencesFromResource(R.xml.preferences);
} }
protected void onoffSummary(String key, int on, int off) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference(key);
if (pref.isChecked()) {
pref.setSummary(on);
} else {
pref.setSummary(off);
}
}
protected void entrySummary(String key) {
ListPreference pref = (ListPreference)findPreference(key);
pref.setSummary(pref.getEntry());
}
protected void textSummary(String key) {
EditTextPreference pref = (EditTextPreference)findPreference(key);
pref.setSummary(getString(R.string.update_history_summ,
pref.getText()));
}
protected void updateSummary(String key) { protected void updateSummary(String key) {
if (key.equals(Preferences.PREF_UPD_INTERVAL)) { if (key.equals(Preferences.PREF_UPD_INTERVAL)) {
@ -79,134 +100,57 @@ public class PreferencesActivity extends PreferenceActivity implements
} else { } else {
pref.setSummary(pref.getEntry()); pref.setSummary(pref.getEntry());
} }
return;
}
if (key.equals(Preferences.PREF_UPD_WIFI_ONLY)) { } else if (key.equals(Preferences.PREF_UPD_WIFI_ONLY)) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference( onoffSummary(key, R.string.automatic_scan_wifi_on,
Preferences.PREF_UPD_WIFI_ONLY); R.string.automatic_scan_wifi_off);
if (pref.isChecked()) {
pref.setSummary(R.string.automatic_scan_wifi_on);
} else {
pref.setSummary(R.string.automatic_scan_wifi_off);
}
return;
}
if (key.equals(Preferences.PREF_UPD_NOTIFY)) { } else if (key.equals(Preferences.PREF_UPD_NOTIFY)) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference( onoffSummary(key, R.string.notify_on,
Preferences.PREF_UPD_NOTIFY); R.string.notify_off);
if (pref.isChecked()) {
pref.setSummary(R.string.notify_on);
} else {
pref.setSummary(R.string.notify_off);
}
return;
}
if (key.equals(Preferences.PREF_UPD_HISTORY)) { } else if (key.equals(Preferences.PREF_UPD_HISTORY)) {
EditTextPreference pref = (EditTextPreference)findPreference( textSummary(key);
Preferences.PREF_UPD_HISTORY);
pref.setSummary(getString(R.string.update_history_summ,
pref.getText()));
return;
}
if (key.equals(Preferences.PREF_COMPACT_LAYOUT)) { } else if (key.equals(Preferences.PREF_PERMISSIONS)) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference( onoffSummary(key, R.string.showPermissions_on,
Preferences.PREF_COMPACT_LAYOUT); R.string.showPermissions_off);
if (pref.isChecked()) {
pref.setSummary(R.string.compactlayout_on);
} else {
pref.setSummary(R.string.compactlayout_off);
}
return;
}
if (key.equals(Preferences.PREF_INCOMP_VER)) { } else if (key.equals(Preferences.PREF_COMPACT_LAYOUT)) {
result ^= RESULT_RELOAD; onoffSummary(key, R.string.compactlayout_on,
setResult(result); R.string.compactlayout_off);
CheckBoxPreference pref = (CheckBoxPreference)findPreference(
Preferences.PREF_INCOMP_VER);
if (pref.isChecked()) {
pref.setSummary(R.string.show_incompat_versions_on);
} else {
pref.setSummary(R.string.show_incompat_versions_off);
}
return;
}
if (key.equals(Preferences.PREF_ROOTED)) { } else if (key.equals(Preferences.PREF_THEME)) {
result ^= RESULT_REFILTER; entrySummary(key);
setResult(result);
CheckBoxPreference pref = (CheckBoxPreference)findPreference(
Preferences.PREF_ROOTED);
if (pref.isChecked()) {
pref.setSummary(R.string.rooted_on);
} else {
pref.setSummary(R.string.rooted_off);
}
return;
}
if (key.equals(Preferences.PREF_IGN_TOUCH)) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference(
Preferences.PREF_IGN_TOUCH);
if (pref.isChecked()) {
pref.setSummary(R.string.ignoreTouch_on);
} else {
pref.setSummary(R.string.ignoreTouch_off);
}
return;
}
if (key.equals(Preferences.PREF_THEME)) {
result |= RESULT_RESTART; result |= RESULT_RESTART;
setResult(result); setResult(result);
ListPreference pref = (ListPreference)findPreference(
Preferences.PREF_THEME);
pref.setSummary(pref.getEntry());
return;
}
if (key.equals(Preferences.PREF_PERMISSIONS)) { } else if (key.equals(Preferences.PREF_INCOMP_VER)) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference( onoffSummary(key, R.string.show_incompat_versions_on,
Preferences.PREF_PERMISSIONS); R.string.show_incompat_versions_off);
if (pref.isChecked()) { result ^= RESULT_RELOAD;
pref.setSummary(R.string.showPermissions_on); setResult(result);
} else {
pref.setSummary(R.string.showPermissions_off);
}
return;
}
if (key.equals(Preferences.PREF_CACHE_APK)) { } else if (key.equals(Preferences.PREF_ROOTED)) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference( onoffSummary(key, R.string.rooted_on,
Preferences.PREF_CACHE_APK); R.string.rooted_off);
if (pref.isChecked()) { result ^= RESULT_REFILTER;
pref.setSummary(R.string.cache_downloaded_on); setResult(result);
} else {
pref.setSummary(R.string.cache_downloaded_off);
}
return;
}
if (key.equals(Preferences.PREF_EXPERT)) { } else if (key.equals(Preferences.PREF_IGN_TOUCH)) {
CheckBoxPreference pref = (CheckBoxPreference)findPreference( onoffSummary(key, R.string.ignoreTouch_on,
Preferences.PREF_EXPERT); R.string.ignoreTouch_off);
if (pref.isChecked()) {
pref.setSummary(R.string.expert_on);
} else {
pref.setSummary(R.string.expert_off);
}
return;
}
if (key.equals(Preferences.PREF_DB_SYNC)) { } else if (key.equals(Preferences.PREF_CACHE_APK)) {
ListPreference pref = (ListPreference)findPreference( onoffSummary(key, R.string.cache_downloaded_on,
Preferences.PREF_DB_SYNC); R.string.cache_downloaded_off);
pref.setSummary(pref.getEntry());
return; } else if (key.equals(Preferences.PREF_EXPERT)) {
onoffSummary(key, R.string.expert_on,
R.string.expert_off);
} else if (key.equals(Preferences.PREF_DB_SYNC)) {
entrySummary(key);
} }
} }