Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ignore xml icons

Browse Source 
They will never work, they should not be set by fdroidserver but we can
be defensive about not returning them to any views here.
This commit is contained in:
Marcus Hoffmann 2020-02-24 16:44:44 +01:00
parent bc6e5e8433
commit 56c05933a2
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/fdroid/fdroid/data/App.java
View File

@ -670,6 +670,11 @@ public class App extends ValueObject implements Comparable<App>, Parcelable {
if (TextUtils.isEmpty(iconFromApk)){ if (TextUtils.isEmpty(iconFromApk)){
return null; return null;
} }
if (iconFromApk.endsWith(".xml")){
// We cannot use xml ressources as icons. F-Droid server should not include them
// https://gitlab.com/fdroid/fdroidserver/issues/344
return null;
}
String iconsDir; String iconsDir;
if (repo.version >= Repo.VERSION_DENSITY_SPECIFIC_ICONS) { if (repo.version >= Repo.VERSION_DENSITY_SPECIFIC_ICONS) {
iconsDir = Utils.getIconsDir(context, 1.0); iconsDir = Utils.getIconsDir(context, 1.0);