From ce1756db625b4d7d99351ea0fa84af6e6ba1759c Mon Sep 17 00:00:00 2001 From: dkanada Date: Thu, 27 Sep 2018 12:05:01 +0900 Subject: [PATCH 1/6] use new design for other badge instances --- .../drawable/app_version_item_status_new.xml | 5 +++++ .../app_version_item_status_suggested.xml | 2 +- .../main/res/layout-v14/app_status_new.xml | 19 ++++--------------- .../res/layout-v14/app_status_suggested.xml | 6 ++++++ .../res/layout/app_details2_version_item.xml | 7 ++----- app/src/main/res/layout/app_status_new.xml | 16 ---------------- 6 files changed, 18 insertions(+), 37 deletions(-) create mode 100644 app/src/main/res/drawable/app_version_item_status_new.xml create mode 100644 app/src/main/res/layout-v14/app_status_suggested.xml delete mode 100644 app/src/main/res/layout/app_status_new.xml diff --git a/app/src/main/res/drawable/app_version_item_status_new.xml b/app/src/main/res/drawable/app_version_item_status_new.xml new file mode 100644 index 000000000..95ed5d276 --- /dev/null +++ b/app/src/main/res/drawable/app_version_item_status_new.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/app/src/main/res/drawable/app_version_item_status_suggested.xml b/app/src/main/res/drawable/app_version_item_status_suggested.xml index 95ed5d276..6f6f0410f 100644 --- a/app/src/main/res/drawable/app_version_item_status_suggested.xml +++ b/app/src/main/res/drawable/app_version_item_status_suggested.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/layout-v14/app_status_new.xml b/app/src/main/res/layout-v14/app_status_new.xml index 0b0e68f04..ade122b9e 100644 --- a/app/src/main/res/layout-v14/app_status_new.xml +++ b/app/src/main/res/layout-v14/app_status_new.xml @@ -1,17 +1,6 @@ - \ No newline at end of file + android:textColor="#429fff" + style="@style/AppVersionStatus" /> \ No newline at end of file diff --git a/app/src/main/res/layout-v14/app_status_suggested.xml b/app/src/main/res/layout-v14/app_status_suggested.xml new file mode 100644 index 000000000..e96aa7255 --- /dev/null +++ b/app/src/main/res/layout-v14/app_status_suggested.xml @@ -0,0 +1,6 @@ + + \ No newline at end of file diff --git a/app/src/main/res/layout/app_details2_version_item.xml b/app/src/main/res/layout/app_details2_version_item.xml index f0e2b7945..794110c1e 100644 --- a/app/src/main/res/layout/app_details2_version_item.xml +++ b/app/src/main/res/layout/app_details2_version_item.xml @@ -41,11 +41,8 @@ android:layout_height="match_parent" android:paddingTop="3dp"> - + - \ No newline at end of file From fef3309714cfe646f5173bf837fe8a880c0812de Mon Sep 17 00:00:00 2001 From: dkanada Date: Thu, 27 Sep 2018 12:06:42 +0900 Subject: [PATCH 2/6] slight changes to update header --- .../updates/items/UpdateableAppsHeader.java | 4 +- .../res/layout/updateable_app_list_item.xml | 30 +++------ app/src/main/res/layout/updates_header.xml | 62 ++++++++++--------- 3 files changed, 43 insertions(+), 53 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java b/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java index 5e5b6a971..beebd062d 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java +++ b/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java @@ -69,16 +69,16 @@ public class UpdateableAppsHeader extends AppUpdateData { private UpdateableAppsHeader header; private final TextView updatesAvailable; - private final ImageView downloadAll; private final TextView appsToUpdate; + private final Button downloadAll; private final Button toggleAppsToUpdate; public ViewHolder(View itemView) { super(itemView); updatesAvailable = (TextView) itemView.findViewById(R.id.text_updates_available); - downloadAll = (ImageView) itemView.findViewById(R.id.button_download_all); appsToUpdate = (TextView) itemView.findViewById(R.id.text_apps_to_update); + downloadAll = (Button) itemView.findViewById(R.id.button_download_all); toggleAppsToUpdate = (Button) itemView.findViewById(R.id.button_toggle_apps_to_update); toggleAppsToUpdate.setOnClickListener(new View.OnClickListener() { diff --git a/app/src/main/res/layout/updateable_app_list_item.xml b/app/src/main/res/layout/updateable_app_list_item.xml index 4e7c1c59e..618ede394 100644 --- a/app/src/main/res/layout/updateable_app_list_item.xml +++ b/app/src/main/res/layout/updateable_app_list_item.xml @@ -5,25 +5,20 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingStart="24dp" - android:paddingLeft="24dp" tools:ignore="RtlSymmetry"> + android:layout_margin="16dp" + tools:ignore="ContentDescription" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toTopOf="parent" /> diff --git a/app/src/main/res/layout/updates_header.xml b/app/src/main/res/layout/updates_header.xml index 4cff7123f..88edde404 100644 --- a/app/src/main/res/layout/updates_header.xml +++ b/app/src/main/res/layout/updates_header.xml @@ -1,35 +1,25 @@ + android:background="?appDetailsCardBackground"> - - + android:layout_marginEnd="16dp" + android:layout_marginRight="16dp" + tools:text="Download updates for 3 apps" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintEnd_toStartOf="@+id/button_download_all" + app:layout_constraintTop_toTopOf="parent" /> +