From ce1756db625b4d7d99351ea0fa84af6e6ba1759c Mon Sep 17 00:00:00 2001
From: dkanada
Date: Thu, 27 Sep 2018 12:05:01 +0900
Subject: [PATCH 1/6] use new design for other badge instances
---
.../drawable/app_version_item_status_new.xml | 5 +++++
.../app_version_item_status_suggested.xml | 2 +-
.../main/res/layout-v14/app_status_new.xml | 19 ++++---------------
.../res/layout-v14/app_status_suggested.xml | 6 ++++++
.../res/layout/app_details2_version_item.xml | 7 ++-----
app/src/main/res/layout/app_status_new.xml | 16 ----------------
6 files changed, 18 insertions(+), 37 deletions(-)
create mode 100644 app/src/main/res/drawable/app_version_item_status_new.xml
create mode 100644 app/src/main/res/layout-v14/app_status_suggested.xml
delete mode 100644 app/src/main/res/layout/app_status_new.xml
diff --git a/app/src/main/res/drawable/app_version_item_status_new.xml b/app/src/main/res/drawable/app_version_item_status_new.xml
new file mode 100644
index 000000000..95ed5d276
--- /dev/null
+++ b/app/src/main/res/drawable/app_version_item_status_new.xml
@@ -0,0 +1,5 @@
+
+
+
+
+
diff --git a/app/src/main/res/drawable/app_version_item_status_suggested.xml b/app/src/main/res/drawable/app_version_item_status_suggested.xml
index 95ed5d276..6f6f0410f 100644
--- a/app/src/main/res/drawable/app_version_item_status_suggested.xml
+++ b/app/src/main/res/drawable/app_version_item_status_suggested.xml
@@ -1,5 +1,5 @@
-
+
diff --git a/app/src/main/res/layout-v14/app_status_new.xml b/app/src/main/res/layout-v14/app_status_new.xml
index 0b0e68f04..ade122b9e 100644
--- a/app/src/main/res/layout-v14/app_status_new.xml
+++ b/app/src/main/res/layout-v14/app_status_new.xml
@@ -1,17 +1,6 @@
-
\ No newline at end of file
+ android:textColor="#429fff"
+ style="@style/AppVersionStatus" />
\ No newline at end of file
diff --git a/app/src/main/res/layout-v14/app_status_suggested.xml b/app/src/main/res/layout-v14/app_status_suggested.xml
new file mode 100644
index 000000000..e96aa7255
--- /dev/null
+++ b/app/src/main/res/layout-v14/app_status_suggested.xml
@@ -0,0 +1,6 @@
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layout/app_details2_version_item.xml b/app/src/main/res/layout/app_details2_version_item.xml
index f0e2b7945..794110c1e 100644
--- a/app/src/main/res/layout/app_details2_version_item.xml
+++ b/app/src/main/res/layout/app_details2_version_item.xml
@@ -41,11 +41,8 @@
android:layout_height="match_parent"
android:paddingTop="3dp">
-
+
-
\ No newline at end of file
From fef3309714cfe646f5173bf837fe8a880c0812de Mon Sep 17 00:00:00 2001
From: dkanada
Date: Thu, 27 Sep 2018 12:06:42 +0900
Subject: [PATCH 2/6] slight changes to update header
---
.../updates/items/UpdateableAppsHeader.java | 4 +-
.../res/layout/updateable_app_list_item.xml | 30 +++------
app/src/main/res/layout/updates_header.xml | 62 ++++++++++---------
3 files changed, 43 insertions(+), 53 deletions(-)
diff --git a/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java b/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java
index 5e5b6a971..beebd062d 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/updates/items/UpdateableAppsHeader.java
@@ -69,16 +69,16 @@ public class UpdateableAppsHeader extends AppUpdateData {
private UpdateableAppsHeader header;
private final TextView updatesAvailable;
- private final ImageView downloadAll;
private final TextView appsToUpdate;
+ private final Button downloadAll;
private final Button toggleAppsToUpdate;
public ViewHolder(View itemView) {
super(itemView);
updatesAvailable = (TextView) itemView.findViewById(R.id.text_updates_available);
- downloadAll = (ImageView) itemView.findViewById(R.id.button_download_all);
appsToUpdate = (TextView) itemView.findViewById(R.id.text_apps_to_update);
+ downloadAll = (Button) itemView.findViewById(R.id.button_download_all);
toggleAppsToUpdate = (Button) itemView.findViewById(R.id.button_toggle_apps_to_update);
toggleAppsToUpdate.setOnClickListener(new View.OnClickListener() {
diff --git a/app/src/main/res/layout/updateable_app_list_item.xml b/app/src/main/res/layout/updateable_app_list_item.xml
index 4e7c1c59e..618ede394 100644
--- a/app/src/main/res/layout/updateable_app_list_item.xml
+++ b/app/src/main/res/layout/updateable_app_list_item.xml
@@ -5,25 +5,20 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:paddingStart="24dp"
- android:paddingLeft="24dp"
tools:ignore="RtlSymmetry">
+ android:layout_margin="16dp"
+ tools:ignore="ContentDescription"
+ app:layout_constraintStart_toStartOf="parent"
+ app:layout_constraintTop_toTopOf="parent" />
diff --git a/app/src/main/res/layout/updates_header.xml b/app/src/main/res/layout/updates_header.xml
index 4cff7123f..88edde404 100644
--- a/app/src/main/res/layout/updates_header.xml
+++ b/app/src/main/res/layout/updates_header.xml
@@ -1,35 +1,25 @@
+ android:background="?appDetailsCardBackground">
-
-
+ android:layout_marginEnd="16dp"
+ android:layout_marginRight="16dp"
+ tools:text="Download updates for 3 apps"
+ app:layout_constraintStart_toStartOf="parent"
+ app:layout_constraintEnd_toStartOf="@+id/button_download_all"
+ app:layout_constraintTop_toTopOf="parent" />
+
+
-
+ android:textColor="@color/fdroid_blue"
+ android:textAllCaps="true"
+ app:layout_constraintStart_toStartOf="parent"
+ app:layout_constraintEnd_toEndOf="parent"
+ app:layout_constraintTop_toBottomOf="@+id/text_apps_to_update" />
\ No newline at end of file
From 3f00b2a4fbf7aaf947dda034974eb8cfc2127dde Mon Sep 17 00:00:00 2001
From: dkanada
Date: Fri, 28 Sep 2018 09:31:33 +0900
Subject: [PATCH 3/6] standardize version properties
---
.../fdroid/views/AppDetailsRecyclerViewAdapter.java | 4 ++--
app/src/main/res/layout/updates_header.xml | 4 ++--
app/src/main/res/values/strings.xml | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
index 5375ac403..a92bb8875 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
@@ -1093,7 +1093,7 @@ public class AppDetailsRecyclerViewAdapter
Repo repo = RepoProvider.Helper.findById(context, apk.repoId);
if (repo != null) {
repository.setVisibility(View.VISIBLE);
- repository.setText(repo.getName());
+ repository.setText("Repository: " + repo.getName());
} else {
repository.setVisibility(View.INVISIBLE);
}
@@ -1170,7 +1170,7 @@ public class AppDetailsRecyclerViewAdapter
}
private String getApiText(final Apk apk) {
- String apiText = "Android ";
+ String apiText = "Version: ";
if (apk.minSdkVersion > 0 && apk.maxSdkVersion < Apk.SDK_VERSION_MAX_VALUE) {
apiText += context.getString(R.string.minsdk_up_to_maxsdk,
Utils.getAndroidVersionName(apk.minSdkVersion),
diff --git a/app/src/main/res/layout/updates_header.xml b/app/src/main/res/layout/updates_header.xml
index 88edde404..b7542efc8 100644
--- a/app/src/main/res/layout/updates_header.xml
+++ b/app/src/main/res/layout/updates_header.xml
@@ -52,10 +52,10 @@
");
}
- sb.append("");
- antiFeaturesView.setText(Html.fromHtml(sb.toString()));
+ antiFeaturesView.setText(trimTrailingNewlines(Html.fromHtml(sb.toString())));
antiFeaturesView.setMovementMethod(LinkMovementMethod.getInstance());
} else {
antiFeaturesView.setVisibility(View.GONE);
@@ -1093,7 +1091,7 @@ public class AppDetailsRecyclerViewAdapter
Repo repo = RepoProvider.Helper.findById(context, apk.repoId);
if (repo != null) {
repository.setVisibility(View.VISIBLE);
- repository.setText("Repository: " + repo.getName());
+ repository.setText(String.format(repo.getName(), context.getString(R.string.app_repository)));
} else {
repository.setVisibility(View.INVISIBLE);
}
@@ -1170,7 +1168,7 @@ public class AppDetailsRecyclerViewAdapter
}
private String getApiText(final Apk apk) {
- String apiText = "Version: ";
+ String apiText = "Android: ";
if (apk.minSdkVersion > 0 && apk.maxSdkVersion < Apk.SDK_VERSION_MAX_VALUE) {
apiText += context.getString(R.string.minsdk_up_to_maxsdk,
Utils.getAndroidVersionName(apk.minSdkVersion),
diff --git a/app/src/main/java/org/fdroid/fdroid/views/updates/UpdatesAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/updates/UpdatesAdapter.java
index 15cf1b6d6..5a93e3e93 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/updates/UpdatesAdapter.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/updates/UpdatesAdapter.java
@@ -138,6 +138,7 @@ public class UpdatesAdapter extends RecyclerView.Adapter
-
-
-
-
\ No newline at end of file
diff --git a/app/src/main/res/drawable/details_panel_donate_background_dark.xml b/app/src/main/res/drawable/details_panel_donate_background_dark.xml
index 722e251c6..34aefb95a 100644
--- a/app/src/main/res/drawable/details_panel_donate_background_dark.xml
+++ b/app/src/main/res/drawable/details_panel_donate_background_dark.xml
@@ -1,6 +1,5 @@
-
\ No newline at end of file
diff --git a/app/src/main/res/drawable/details_panel_donate_background_light.xml b/app/src/main/res/drawable/details_panel_donate_background_light.xml
index aed890e90..229c42b8b 100644
--- a/app/src/main/res/drawable/details_panel_donate_background_light.xml
+++ b/app/src/main/res/drawable/details_panel_donate_background_light.xml
@@ -1,6 +1,5 @@
-
\ No newline at end of file
diff --git a/app/src/main/res/drawable/details_panel_donate_background_night.xml b/app/src/main/res/drawable/details_panel_donate_background_night.xml
index 544639559..261466f71 100644
--- a/app/src/main/res/drawable/details_panel_donate_background_night.xml
+++ b/app/src/main/res/drawable/details_panel_donate_background_night.xml
@@ -1,6 +1,5 @@
-
\ No newline at end of file
diff --git a/app/src/main/res/layout/app_details2_header.xml b/app/src/main/res/layout/app_details2_header.xml
index b525cd58e..fb0805bc2 100755
--- a/app/src/main/res/layout/app_details2_header.xml
+++ b/app/src/main/res/layout/app_details2_header.xml
@@ -12,13 +12,13 @@
+ android:paddingTop="8dp"
+ android:paddingBottom="8dp"
+ android:orientation="vertical">
-
@@ -86,10 +85,6 @@
android:id="@+id/progress_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_alignParentEnd="true"
- android:layout_alignParentLeft="true"
- android:layout_alignParentRight="true"
- android:layout_alignParentStart="true"
android:layout_below="@id/icon_and_name"
tools:visibility="gone">
@@ -120,7 +115,7 @@
android:layout_height="wrap_content"
android:layout_toLeftOf="@id/progress_cancel"
android:layout_toStartOf="@id/progress_cancel"
- android:text=""
+ tools:text="500%"
android:textAppearance="@style/TextAppearance.AppCompat.Small" />
+
+
+ android:textAppearance="@style/TextAppearance.AppCompat.Body1" />
+ tools:text="\t• This app tracks and reports your activity."
+ android:textAppearance="@style/TextAppearance.AppCompat.Body1" />
-
-
-
+ style="@style/DetailsMoreButtonStyle" />
diff --git a/app/src/main/res/layout/app_details2_version_item.xml b/app/src/main/res/layout/app_details2_version_item.xml
index 794110c1e..8bd5fc2a7 100644
--- a/app/src/main/res/layout/app_details2_version_item.xml
+++ b/app/src/main/res/layout/app_details2_version_item.xml
@@ -41,9 +41,6 @@
android:layout_height="match_parent"
android:paddingTop="3dp">
-
-
+
+
+ android:layout_height="wrap_content"
+ android:background="?appDetailsCardBackground">
+ android:layout_marginBottom="8dp"
+ android:scaleType="fitCenter"
+ tools:src="@drawable/ic_launcher"
+ tools:ignore="ContentDescription"
+ app:layout_constraintStart_toStartOf="parent"
+ app:layout_constraintTop_toTopOf="parent"
+ app:layout_constraintBottom_toBottomOf="parent" />
-
+ app:layout_constraintBottom_toTopOf="@id/progress_bar"
+ android:orientation="vertical">
-
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layout/updates_header.xml b/app/src/main/res/layout/updates_header.xml
index b7542efc8..158198273 100644
--- a/app/src/main/res/layout/updates_header.xml
+++ b/app/src/main/res/layout/updates_header.xml
@@ -25,13 +25,13 @@
android:id="@+id/text_apps_to_update"
android:layout_width="0dp"
android:layout_height="wrap_content"
- tools:text="SAnd, Birthday Droid, Dados D, Other app, Another app"
- android:maxLines="1"
- android:ellipsize="end"
android:layout_marginStart="16dp"
android:layout_marginLeft="16dp"
android:layout_marginEnd="16dp"
android:layout_marginRight="16dp"
+ android:maxLines="1"
+ android:ellipsize="end"
+ tools:text="SAnd, Birthday Droid, Dados D, Other app, Another app"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toStartOf="@+id/button_download_all"
app:layout_constraintTop_toBottomOf="@+id/text_updates_available" />
@@ -40,11 +40,10 @@
android:id="@+id/button_download_all"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:layout_marginEnd="8dp"
- android:layout_marginRight="8dp"
- android:text="Update all"
+ android:layout_marginEnd="16dp"
+ android:layout_marginRight="16dp"
android:textAllCaps="true"
- android:contentDescription="@string/updates__tts__download_updates_for_all_apps"
+ android:text="@string/updates__tts__download_updates_for_all_apps"
style="@style/DetailsPrimaryButtonStyle"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="@+id/text_updates_available"
@@ -52,7 +51,7 @@