Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'fix-empty-message-display' into 'master'

Browse Source 
Ensure the "no apps to display" doesn't overlap with the category spinner.

There is no layout .xml file for the updated/installed list,
but there is for the available apps list. As a result, the `TextView` containing
the empty list message is added dynamically. With the recent improvements to
the category spinner, a `RelativeLayout` was used instead of a `ListView`. To
remedy this, the layout has been augmented to ensure the dynamically added
`TextView` still displays correctly.

*Before:*

![before](/uploads/15e8dca7a98c6ed2e302e33934cddd52/before.png)

*After:*

![after](/uploads/88de17059d84c6c2bf97d108f3504905/after.png)

See merge request !162
This commit is contained in:
Peter Serwylo 2015-11-06 22:43:27 +00:00
commit 5307d56ee5
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
F-Droid/res/layout/available_app_list.xml
View File

@ -19,11 +19,21 @@
android:layout_alignBottom="@id/category_spinner"
android:background="@color/fdroid_green" />
<ListView
android:id="@android:id/list"
android:fastScrollEnabled="true"
<!-- The empty app list message gets shown on the parent of the @android:id/list.
For the update/installed lists, this is not a problem as it is attached to the linear
layout the list is in. However here, it will end up in the relative layout which
causes sadness. This FrameLayout is here so that the empty message will get shown here. -->
<FrameLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_below="@id/category_spinner" />
android:layout_below="@id/category_spinner">
<ListView
android:id="@android:id/list"
android:fastScrollEnabled="true"
android:layout_width="match_parent"
android:layout_height="match_parent" />
</FrameLayout>
</RelativeLayout>