From 4f717c663bce10f1140446598882dc8fb0054da1 Mon Sep 17 00:00:00 2001
From: Aleksey Tulinov <aleksey.tulinov@gmail.com>
Date: Sun, 17 Nov 2013 06:23:12 +0200
Subject: [PATCH] Issue #413: removed "compacts" array to always re-layout
 reused views

---
 .../fdroid/fdroid/views/AppListAdapter.java   | 21 +++++++------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/src/org/fdroid/fdroid/views/AppListAdapter.java b/src/org/fdroid/fdroid/views/AppListAdapter.java
index ef7f4f3fa..1edb46ed9 100644
--- a/src/org/fdroid/fdroid/views/AppListAdapter.java
+++ b/src/org/fdroid/fdroid/views/AppListAdapter.java
@@ -20,7 +20,6 @@ abstract public class AppListAdapter extends BaseAdapter {
 
     private List<DB.App> items = new ArrayList<DB.App>();
     private Context mContext;
-    private List<Boolean> compacts = new ArrayList<Boolean>();
 
     public AppListAdapter(Context context) {
         mContext = context;
@@ -32,12 +31,10 @@ abstract public class AppListAdapter extends BaseAdapter {
 
     public void addItem(DB.App app) {
         items.add(app);
-        compacts.add(null);
     }
 
     public void clear() {
         items.clear();
-        compacts.clear();
     }
 
     @Override
@@ -75,19 +72,15 @@ abstract public class AppListAdapter extends BaseAdapter {
         name.setText(app.name);
         summary.setText(app.summary);
 
-        Boolean storedCompact = compacts.get(position);
-        if (storedCompact == null || compact != storedCompact) {
-            int visibleOnCompact = compact ? View.VISIBLE : View.GONE;
-            int notVisibleOnCompact = compact ? View.GONE : View.VISIBLE;
+        int visibleOnCompact = compact ? View.VISIBLE : View.GONE;
+        int notVisibleOnCompact = compact ? View.GONE : View.VISIBLE;
 
-            LinearLayout iconContainer = (LinearLayout)convertView.findViewById(R.id.status_icons);
+        LinearLayout iconContainer = (LinearLayout)convertView.findViewById(R.id.status_icons);
 
-            iconContainer.setVisibility(visibleOnCompact);
-            status.setVisibility(notVisibleOnCompact);
-            license.setVisibility(notVisibleOnCompact);
-            compacts.set(position, compact);
-            layoutSummary(summary);
-        }
+        iconContainer.setVisibility(visibleOnCompact);
+        status.setVisibility(notVisibleOnCompact);
+        license.setVisibility(notVisibleOnCompact);
+        layoutSummary(summary);
 
         ImageLoader.getInstance().displayImage(app.iconUrl, icon);