Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

document processes in CleanCacheService

Browse Source 
This breaks out each separate process into its own utility method, and adds
javadoc to describe them.
This commit is contained in:
Hans-Christoph Steiner 2016-08-16 16:50:04 +02:00
parent 0614213de0
commit 4dc1415035
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/src/main/java/org/fdroid/fdroid/CleanCacheService.java
View File

@ -23,7 +23,14 @@ import java.util.concurrent.TimeUnit;
* Handles cleaning up caches files that are not going to be used, and do not * Handles cleaning up caches files that are not going to be used, and do not
* block the operation of the app itself. For things that must happen before * block the operation of the app itself. For things that must happen before
* F-Droid starts normal operation, that should go into * F-Droid starts normal operation, that should go into
* {@link FDroidApp#onCreate()} * {@link FDroidApp#onCreate()}.
* <p>
* These files should only be deleted when they are at least an hour-ish old,
* in case they are actively in use while {@code CleanCacheService} is running.
* {@link #clearOldFiles(File, long)} checks the file age using access time from
* {@link StructStat#st_atime} on {@link android.os.Build.VERSION_CODES#LOLLIPOP}
* and newer. On older Android, last modified time from {@link File#lastModified()}
* is used.
*/ */
public class CleanCacheService extends IntentService { public class CleanCacheService extends IntentService {
@ -58,12 +65,22 @@ public class CleanCacheService extends IntentService {
return; return;
} }
Process.setThreadPriority(Process.THREAD_PRIORITY_LOWEST); Process.setThreadPriority(Process.THREAD_PRIORITY_LOWEST);
clearOldFiles(ApkCache.getApkCacheDir(getBaseContext()), Preferences.get().getKeepCacheTime()); deleteExpiredApksFromCache();
deleteStrayIndexFiles(); deleteStrayIndexFiles();
deleteOldInstallerFiles(); deleteOldInstallerFiles();
deleteOldIcons(); deleteOldIcons();
} }
/**
* All downloaded APKs will be cached for a certain amount of time, which is
* specified by the user in the "Keep Cache Time" preference. This removes
* any APK in the cache that is older than that preference specifies.
*/
private void deleteExpiredApksFromCache() {
File cacheDir = ApkCache.getApkCacheDir(getBaseContext());
clearOldFiles(cacheDir, Preferences.get().getKeepCacheTime());
}
/** /**
* {@link org.fdroid.fdroid.installer.Installer} instances copy the APK into * {@link org.fdroid.fdroid.installer.Installer} instances copy the APK into
* a safe place before installing. It doesn't clean up them reliably yet. * a safe place before installing. It doesn't clean up them reliably yet.

2
app/src/main/java/org/fdroid/fdroid/Preferences.java
View File

@ -71,7 +71,7 @@ public final class Preferences implements SharedPreferences.OnSharedPreferenceCh
private static final int DEFAULT_UPD_HISTORY = 14; private static final int DEFAULT_UPD_HISTORY = 14;
private static final boolean DEFAULT_PRIVILEGED_INSTALLER = false; private static final boolean DEFAULT_PRIVILEGED_INSTALLER = false;
//private static final boolean DEFAULT_LOCAL_REPO_BONJOUR = true; //private static final boolean DEFAULT_LOCAL_REPO_BONJOUR = true;
private static final long DEFAULT_KEEP_CACHE_TIME = TimeUnit.DAYS.toMillis(1); // one day private static final long DEFAULT_KEEP_CACHE_TIME = TimeUnit.DAYS.toMillis(1);
private static final boolean DEFAULT_UNSTABLE_UPDATES = false; private static final boolean DEFAULT_UNSTABLE_UPDATES = false;
//private static final boolean DEFAULT_LOCAL_REPO_HTTPS = false; //private static final boolean DEFAULT_LOCAL_REPO_HTTPS = false;
private static final boolean DEFAULT_INCOMP_VER = false; private static final boolean DEFAULT_INCOMP_VER = false;