From 4b922f38b93d4ba5ffe7aa4bc27ecb0f1e48e8c6 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 1 Sep 2016 15:49:15 +0200 Subject: [PATCH] don't show notification if the app name is unknown #720 This gets rid of the notifications that say "Tap to Install Unknown", and instead just cancels the notification. The downloaded APK will still be cached, so when the user goes to click install or update again, it won't need to download it again. closes #758 --- .../org/fdroid/fdroid/installer/InstallManagerService.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java b/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java index eb77f757e..320789a5f 100644 --- a/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java +++ b/app/src/main/java/org/fdroid/fdroid/installer/InstallManagerService.java @@ -331,7 +331,12 @@ public class InstallManagerService extends Service { title = String.format(getString(R.string.tap_to_update_format), pm.getApplicationLabel(pm.getApplicationInfo(apk.packageName, 0))); } catch (PackageManager.NameNotFoundException e) { - title = String.format(getString(R.string.tap_to_install_format), getAppName(apk)); + // TODO use packageName to fetch App instance from database if not cached + String name = getAppName(apk); + if (TextUtils.isEmpty(name) || name.equals(new App().name)) { + return; // do not have a name to display, so leave notification as is + } + title = String.format(getString(R.string.tap_to_install_format), name); } int downloadUrlId = urlString.hashCode();