From 6f3c5b4e85b5021e59c994eefeb8e170b26cfa54 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sun, 26 May 2013 12:25:20 +0200
Subject: [PATCH 1/3] More spacings in lists and app details screen

---
 res/layout/appdetails.xml             | 5 ++++-
 res/layout/applistitem.xml            | 2 +-
 src/org/fdroid/fdroid/AppDetails.java | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/res/layout/appdetails.xml b/res/layout/appdetails.xml
index 45fe822b0..addc35982 100644
--- a/res/layout/appdetails.xml
+++ b/res/layout/appdetails.xml
@@ -2,6 +2,9 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="fill_parent"
     android:layout_height="fill_parent"
+    android:paddingTop="5dp"
+    android:paddingLeft="8dp"
+    android:paddingRight="8dp"
     android:orientation="vertical" >
 
     <LinearLayout
@@ -56,4 +59,4 @@
         android:layout_width="fill_parent"
         android:layout_height="fill_parent" />
 
-</LinearLayout>
\ No newline at end of file
+</LinearLayout>
diff --git a/res/layout/applistitem.xml b/res/layout/applistitem.xml
index f2f11e132..4abc1ab60 100644
--- a/res/layout/applistitem.xml
+++ b/res/layout/applistitem.xml
@@ -3,7 +3,7 @@
 		android:orientation="vertical"
 		android:layout_width="fill_parent"
 		android:layout_height="wrap_content"
-		android:paddingTop="0dp"
+		android:paddingTop="3dp"
 		android:paddingBottom="4dp"
 		android:paddingLeft="6dp"
 		android:paddingRight="10dp">
diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java
index aca27650e..ed177834d 100644
--- a/src/org/fdroid/fdroid/AppDetails.java
+++ b/src/org/fdroid/fdroid/AppDetails.java
@@ -116,7 +116,7 @@ public class AppDetails extends ListActivity {
             TextView version = (TextView) v.findViewById(R.id.version);
             boolean iscurrent = apk.vercode == app_currentvercode;
             version.setText(getString(R.string.version) + " " + apk.version
-                    + (iscurrent ? "*" : ""));
+                    + (iscurrent ? " *" : ""));
 
             // TODO: This will show 'Installed' for all apks with the same
             // version code, which could be more than one if they come from

From 18ae6e6da23e21ab451a4189bd0463a412863392 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sun, 26 May 2013 12:25:46 +0200
Subject: [PATCH 2/3] Refactor about screen.

* Add paddings.
* Don't use hard-coded pixel sizes.
* Don't use white color directly (this would soon break the white holo theme)
* Don't use an "empty" textview to force a vertical space.

Looks much cleaner now, and the code is easier on the eyes.
---
 res/layout/about.xml   | 65 +++++++++++++++++++++++++++---------------
 res/values/strings.xml |  1 -
 2 files changed, 42 insertions(+), 24 deletions(-)

diff --git a/res/layout/about.xml b/res/layout/about.xml
index d8403f176..f9ba30dbe 100644
--- a/res/layout/about.xml
+++ b/res/layout/about.xml
@@ -1,52 +1,71 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-	android:layout_width="fill_parent" android:layout_height="fill_parent"
-	android:orientation="vertical" android:paddingLeft="5px">
+    android:layout_width="fill_parent"
+    android:layout_height="fill_parent"
+    android:paddingLeft="8dp"
+    android:paddingRight="8dp"
+    android:paddingTop="6dp"
+    android:paddingBottom="6dp"
+    android:orientation="vertical">
 
 	<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-		android:layout_width="fill_parent" android:layout_height="fill_parent"
+        android:layout_width="fill_parent"
+        android:layout_height="fill_parent"
 		android:orientation="horizontal">
 
 		<TextView android:text="@string/about_version"
-			android:layout_width="wrap_content" android:layout_height="wrap_content"
-			android:textSize="16px" android:textColor="#ffffff" />
+            android:textStyle="bold"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
-		<TextView android:id="@+id/version" android:layout_width="wrap_content"
+        <TextView android:id="@+id/version"
+            android:paddingLeft="5dp"
+            android:layout_width="wrap_content"
 			android:layout_height="wrap_content" />
 
 	</LinearLayout>
 
 	<LinearLayout android:layout_width="fill_parent"
-		android:layout_height="fill_parent" android:orientation="horizontal">
+        android:layout_height="fill_parent"
+        android:orientation="horizontal">
 
-		<TextView android:id="@+id/site" android:text="@string/about_site"
-			android:layout_width="wrap_content" android:layout_height="wrap_content"
-			android:textSize="16px" android:textColor="#ffffff" />
+        <TextView android:id="@+id/site"
+            android:text="@string/about_site"
+            android:textStyle="bold"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
-		<TextView android:id="@+id/sitec" android:text="@string/about_sitec"
-			android:layout_width="wrap_content" android:layout_height="wrap_content" />
+        <TextView android:id="@+id/sitec"
+            android:text="@string/about_sitec"
+            android:paddingLeft="5dp"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
 	</LinearLayout>
 
 	<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-		android:layout_width="fill_parent" android:layout_height="fill_parent"
+        android:layout_width="fill_parent"
+        android:layout_height="fill_parent"
 		android:orientation="horizontal">
 
-		<TextView android:id="@+id/mail" android:text="@string/about_mail"
-			android:layout_width="wrap_content" android:layout_height="wrap_content"
-			android:textSize="16px" android:textColor="#ffffff" />
+        <TextView android:id="@+id/mail"
+            android:text="@string/about_mail"
+            android:textStyle="bold"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content" />
 
-		<TextView android:id="@+id/mailc" android:text="@string/about_mailc"
-			android:autoLink="email" android:layout_width="wrap_content"
+        <TextView android:id="@+id/mailc"
+            android:text="@string/about_mailc"
+            android:paddingLeft="5dp"
+            android:autoLink="email"
+            android:layout_width="wrap_content"
 			android:layout_height="wrap_content" />
 
 	</LinearLayout>
 
-	<TextView android:id="@+id/not" android:text="@string/about_not"
-		android:layout_width="wrap_content" android:layout_height="wrap_content" />
-
 	<TextView android:text="@string/about_desc"
-		android:layout_width="fill_parent" android:layout_height="fill_parent"
-		android:textSize="16px" />
+        android:paddingTop="5dp"
+        android:layout_width="fill_parent"
+        android:layout_height="fill_parent" />
 
 </LinearLayout>
diff --git a/res/values/strings.xml b/res/values/strings.xml
index 24e579438..7b1b70f49 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -36,7 +36,6 @@
 	<string name="about_mailc">admin@f-droid.org</string>
 	<string name="about_version">Version: </string>
 	<string name="about_website">Website</string>
-	<string name="about_not"> </string>
 
 	<string name="no_repo">You don\'t have any repositories configured!\n\nA
 		repository is a source of applications. To add one, press the MENU

From 780e0e3d54adea86434c2509474781405cb0872b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Mon, 27 May 2013 18:08:24 +0200
Subject: [PATCH 3/3] Some more spacing fixes (suggestion by daithib8)

---
 res/layout-land/appdetails.xml | 3 ++-
 res/layout/apklistitem.xml     | 4 ++--
 res/layout/applistitem.xml     | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/res/layout-land/appdetails.xml b/res/layout-land/appdetails.xml
index 19ecbfc22..de44ee123 100644
--- a/res/layout-land/appdetails.xml
+++ b/res/layout-land/appdetails.xml
@@ -14,6 +14,7 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_margin="5dp"
+            android:paddingRight="6dp"
             android:orientation="vertical" >
 
             <RelativeLayout
@@ -66,4 +67,4 @@
         android:layout_height="fill_parent"
         android:layout_weight="0.5" />
 
-</LinearLayout>
\ No newline at end of file
+</LinearLayout>
diff --git a/res/layout/apklistitem.xml b/res/layout/apklistitem.xml
index bf733353a..03578dc06 100644
--- a/res/layout/apklistitem.xml
+++ b/res/layout/apklistitem.xml
@@ -5,8 +5,8 @@
 		android:orientation="vertical"
 		android:paddingTop="5dp"
 		android:paddingBottom="5dp"
-		android:paddingLeft="10dp"
-		android:paddingRight="10dp">
+		android:paddingLeft="2dp"
+		android:paddingRight="2dp">
 
   <TextView android:id="@+id/buildtype"
 	    android:textSize="12sp"
diff --git a/res/layout/applistitem.xml b/res/layout/applistitem.xml
index 4abc1ab60..d96f3bccd 100644
--- a/res/layout/applistitem.xml
+++ b/res/layout/applistitem.xml
@@ -22,6 +22,7 @@
 	    android:layout_width="fill_parent"
 	    android:layout_height="wrap_content"
 	    android:layout_toRightOf="@id/icon"
+	    android:paddingTop="4dp"
 	    android:paddingBottom="2dp"
 	    android:paddingLeft="1dp"/>
 
@@ -51,6 +52,6 @@
 	    android:layout_width="fill_parent"
 	    android:layout_height="wrap_content"
 	    android:layout_below="@id/icon"
-	    android:paddingLeft="4dp"/>
+	    android:paddingLeft="6dp"/>
 
 </RelativeLayout>